Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1555683002: [Draft] RTCP Parser sketched. (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, pbos-webrtc, åsapersson, terelius
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] RTCP Parser sketched. alternative approach to CL#1476793002: instead of copying RTCP header class as is, this CL adds buffer pointer to it. This allows to use the resulting class as iterator going through individual packets in compound RTCP packet. sample1 demonstrates how it can be used directly with a template functions sample2 - how it can be used indirectly with template functions sample4 introduce generic parser written with template meta-programming. Set of supported packets to parser can be configured at runtime. BUG=webrtc:5260 COMMIT=false

Patch Set 1 #

Patch Set 2 : Sample code explicetly separated #

Patch Set 3 : Add Parser that gives back base RtcpPacket classes, but nicely. #

Patch Set 4 : rebase & ParsingPacket renamed to CommonHeader #

Patch Set 5 : Rebase; remove virtal-packet parsed, added functor-based parser. #

Patch Set 6 : fix RtcpParser* tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -3 lines) Patch
M webrtc/modules/BUILD.gn View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/parsing_container.h View 1 2 3 4 5 1 chunk +80 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_parser_unittest1.cc View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_parser_unittest2.cc View 1 2 3 4 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_parser_unittest4.cc View 1 2 3 4 5 1 chunk +104 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_rtcp_parser1.h View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_rtcp_parser2.h View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/sample_rtcp_parser4.h View 1 2 3 4 5 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
danilchap
Description was changed from ========== [rtp_rtcp] RTCP Parser sketched. alternative approach to CL#1476793002: instead of ...
4 years, 11 months ago (2016-01-11 10:01:13 UTC) #1
danilchap
Description was changed from ========== [rtp_rtcp] RTCP Parser sketched. alternative approach to CL#1476793002: instead of ...
4 years, 11 months ago (2016-01-14 14:49:18 UTC) #2
danilchap
danilchap@webrtc.org changed reviewers: - asapersson@webrtc.org, sprang@webrtc.org
4 years, 10 months ago (2016-02-12 10:05:01 UTC) #3
danilchap
Description was changed from ========== [rtp_rtcp] RTCP Parser sketched. alternative approach to CL#1476793002: instead of ...
4 years, 10 months ago (2016-02-12 15:18:21 UTC) #4
danilchap
4 years, 4 months ago (2016-08-15 08:19:15 UTC) #5
Description was changed from

==========
[rtp_rtcp] RTCP Parser sketched.

alternative approach to CL#1476793002:
instead of copying RTCP header class as is, this CL adds buffer pointer to it.
This allows to use the resulting class as iterator going through individual
packets in compound RTCP packet.

sample_rtcp_parser0 demonstrate how Parser can look like without new
CommonHeader class.
other sample_rtcp_parser demonstrate slightly different ways how CommonHeader
can be used:
 sample1 demonstrates how it can be used directly with a template functions
 sample2 - how it can be used indirectly with template functions
 sample3 demonstrates how it can be used without template functions.

BUG=webrtc:5260
COMMIT=false
==========

to

==========
[rtp_rtcp] RTCP Parser sketched.

alternative approach to CL#1476793002:
instead of copying RTCP header class as is, this CL adds buffer pointer to it.
This allows to use the resulting class as iterator going through individual
packets in compound RTCP packet.

 sample1 demonstrates how it can be used directly with a template functions
 sample2 - how it can be used indirectly with template functions
 sample4 introduce generic parser written with template meta-programming. Set of
supported packets to parser can be
configured at runtime.

BUG=webrtc:5260
COMMIT=false
==========

Powered by Google App Engine
This is Rietveld 408576698