Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1555673002: Add ImplementationName to SimulcastEncoderAdapter. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add ImplementationName to SimulcastEncoderAdapter. BUG=webrtc:4897 R=stefan@webrtc.org Committed: https://crrev.com/ecd21b481fc2f01b19044b23856ef6b95826f237 Cr-Commit-Position: refs/heads/master@{#11170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pbos-webrtc
PTAL
4 years, 11 months ago (2015-12-30 17:05:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555673002/1
4 years, 11 months ago (2016-01-07 14:25:12 UTC) #5
stefan-webrtc
lgtm
4 years, 11 months ago (2016-01-07 14:26:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555673002/1
4 years, 11 months ago (2016-01-07 14:33:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 16:03:08 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 16:03:23 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ecd21b481fc2f01b19044b23856ef6b95826f237
Cr-Commit-Position: refs/heads/master@{#11170}

Powered by Google App Engine
This is Rietveld 408576698