Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1554673002: Disabling CritSectTest on Windows DrMemory bot. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabling CritSectTest on Windows DrMemory bot. BUG=webrtc:5390 Committed: https://crrev.com/523702136f39cdbf0ac32d7173834ccf06744461 Cr-Commit-Position: refs/heads/master@{#11148}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Trying to fix patch failure #

Patch Set 4 : Fixing line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/system_wrappers_unittests.gtest-drmemory_win32.txt View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Taylor Brandstetter
4 years, 11 months ago (2015-12-29 22:21:52 UTC) #2
Taylor Brandstetter
Hmm, any idea why I keep getting a patch failure? I don't understand what the ...
4 years, 11 months ago (2015-12-30 00:51:30 UTC) #3
kjellander_webrtc
On 2015/12/30 00:51:30, Taylor Brandstetter wrote: > Hmm, any idea why I keep getting a ...
4 years, 11 months ago (2016-01-04 12:20:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554673002/60001
4 years, 11 months ago (2016-01-04 18:51:00 UTC) #6
kjellander_webrtc
On 2016/01/04 18:51:00, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 11 months ago (2016-01-04 19:10:43 UTC) #7
Taylor Brandstetter
On 2016/01/04 19:10:43, kjellander (webrtc) wrote: > On 2016/01/04 18:51:00, commit-bot: I haz the power ...
4 years, 11 months ago (2016-01-04 19:15:09 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-04 19:50:49 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 19:50:56 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/523702136f39cdbf0ac32d7173834ccf06744461
Cr-Commit-Position: refs/heads/master@{#11148}

Powered by Google App Engine
This is Rietveld 408576698