Move fake-handle frame creation into test target.

Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org

Committed: https://crrev.com/13f61dfea59a546e4e0081eb79e38c542ec51cf6
Cr-Commit-Position: refs/heads/master@{#11149}

[pbos-webrtc, 2016-01-04 18:49:20]

PTAL

[pbos-webrtc, 2016-01-04 18:49:25]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 18:49:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554223002/1

[commit-bot: I haz the power, 2016-01-04 18:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 18:51:48]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4299)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/6613)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10437)
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/11580)
  mac_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/11478)

[pbos-webrtc, 2016-01-04 18:53:31]

add file

[pbos-webrtc, 2016-01-04 18:53:45]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 18:53:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554223002/20001

[kjellander_webrtc, 2016-01-04 19:16:38]

lgtm with nits. 
Thanks for the super-quick fix.

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
File webrtc/test/fake_texture_frame.cc (right):

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.cc:2: *  Copyright (c) 2015 The WebRTC project
authors. All Rights Reserved.
this should be 2016 though.

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.cc:11: #include
"webrtc/test/fake_texture_frame.h"
nit: blank line after #include.

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
File webrtc/test/fake_texture_frame.h (right):

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.h:2: *  Copyright (c) 2016 The WebRTC project
authors. All Rights Reserved.
This file already existed, so it should actually be 2015, no?

[commit-bot: I haz the power, 2016-01-04 20:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 20:18:05]

Dry run: This issue passed the CQ dry run.

[pbos-webrtc, 2016-01-04 21:35:19]

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
File webrtc/test/fake_texture_frame.cc (right):

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.cc:2: *  Copyright (c) 2015 The WebRTC project
authors. All Rights Reserved.
On 2016/01/04 19:16:37, kjellander (webrtc) wrote:
> this should be 2016 though.

Done.

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.cc:11: #include
"webrtc/test/fake_texture_frame.h"
On 2016/01/04 19:16:38, kjellander (webrtc) wrote:
> nit: blank line after #include.

Done.

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
File webrtc/test/fake_texture_frame.h (right):

https://codereview.webrtc.org/1554223002/diff/20001/webrtc/test/fake_texture_...
webrtc/test/fake_texture_frame.h:2: *  Copyright (c) 2016 The WebRTC project
authors. All Rights Reserved.
On 2016/01/04 19:16:38, kjellander (webrtc) wrote:
> This file already existed, so it should actually be 2015, no?

Oops, changed the wrong file. :)

[pbos-webrtc, 2016-01-04 21:35:32]

kjellander@ review

[pbos-webrtc, 2016-01-04 21:36:15]

Description was changed from

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
==========

to

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org
==========

[pbos-webrtc, 2016-01-04 21:36:15]

pbos@webrtc.org changed reviewers:
+ stefan@webrtc.org

[pbos-webrtc, 2016-01-04 21:36:29]

+TBR stefan@ for webrtc/common_video

[pbos-webrtc, 2016-01-04 21:36:53]

Description was changed from

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org
==========

to

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/13f61dfea59a546e4e0081eb7...
==========

[commit-bot: I haz the power, 2016-01-04 21:36:53]

Description was changed from

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/13f61dfea59a546e4e0081eb7...
==========

to

==========
Move fake-handle frame creation into test target.

Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.

Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.

BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org

Committed: https://crrev.com/13f61dfea59a546e4e0081eb79e38c542ec51cf6
Cr-Commit-Position: refs/heads/master@{#11149}
==========

[commit-bot: I haz the power, 2016-01-04 21:36:54]

Patchset 3 (id:??) landed as
https://crrev.com/13f61dfea59a546e4e0081eb79e38c542ec51cf6
Cr-Commit-Position: refs/heads/master@{#11149}

[pbos-webrtc, 2016-01-04 21:36:54]

Committed patchset #3 (id:40001) manually as
13f61dfea59a546e4e0081eb79e38c542ec51cf6 (presubmit successful).