Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1554163002: iOS stability improvement for device switching (Closed)

Created:
4 years, 11 months ago by henrika_webrtc
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS stability improvement for device switching, including BT devices BUG=webrtc:5058 Committed: https://crrev.com/30166cb1a8d7ca2d67981927d056e60aa58cb1ae Cr-Commit-Position: refs/heads/master@{#11168}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
henrika_webrtc
Adding new modifications which ensures that we can perform device switching between different types of ...
4 years, 11 months ago (2016-01-04 15:58:51 UTC) #3
henrika_webrtc
Zeke, do you mind checking this CL? I will run tests on more devices and ...
4 years, 11 months ago (2016-01-04 16:03:12 UTC) #4
tkchin_webrtc
On 2016/01/04 16:03:12, henrika_webrtc wrote: > Zeke, do you mind checking this CL? I will ...
4 years, 11 months ago (2016-01-04 17:17:11 UTC) #5
henrika_webrtc
Thanks, just want to run some more tests first. Expect this one to land on ...
4 years, 11 months ago (2016-01-05 08:16:00 UTC) #6
henrika_webrtc
Tried more devices and it seems to work well so far. Landing as is.
4 years, 11 months ago (2016-01-07 13:44:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554163002/40001
4 years, 11 months ago (2016-01-07 13:44:14 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-07 15:23:05 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 15:23:16 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30166cb1a8d7ca2d67981927d056e60aa58cb1ae
Cr-Commit-Position: refs/heads/master@{#11168}

Powered by Google App Engine
This is Rietveld 408576698