Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552863002: Fix a -Wunused-function warning in gn builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a -Wunused-function warning in gn builds. BUG=chromium:573250 Committed: https://crrev.com/06689a1d17c15002e02d08e4299b6842693431cd Cr-Commit-Position: refs/heads/master@{#11145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/base/network.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
First to stamp wins!
4 years, 11 months ago (2015-12-30 20:35:55 UTC) #2
pthatcher1
lgtm
4 years, 11 months ago (2015-12-30 22:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552863002/1
4 years, 11 months ago (2015-12-30 22:11:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 23:05:34 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 23:05:43 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06689a1d17c15002e02d08e4299b6842693431cd
Cr-Commit-Position: refs/heads/master@{#11145}

Powered by Google App Engine
This is Rietveld 408576698