[rtp_rtcp] rtcp::Remb cleaned and got Parse function

uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/d8dccd57ea39ef7ce5f2fcb9b133be33fe1c6687
Cr-Commit-Position: refs/heads/master@{#11324}

[danilchap, 2016-01-15 13:27:55]

Description was changed from

==========
[rtp_rtcp] rtcp::Remb moved into own file and got Parse function

BUG=webrtc:5260
R=åsapersson
==========

to

==========
uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson
==========

[åsapersson, 2016-01-20 15:33:13]

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc:107:
RTC_DCHECK_EQ(Psfb::media_ssrc(), 0u);
RTC_DCHECK_EQ(0u, ...

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h:53: static const uint32_t
kSignature = 0x52454D42;  // 'R' 'E' 'M' 'B'.
perhaps call kUniqueIdentifier (as in figure)

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h:59: uint32_t bitrate_;
call this bitrate_bps_?

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:28: const uint32_t
kRemoteSsrc[] = {0x23456789, 0x2345678a, 0x2345678b};
s/kRemoteSsrc/kRemoteSsrcs

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:67:
TEST(RtcpPacketRembTest, CreateAndParseEmpty) {
maybe CreateAndParseWithSsrcCountZero or similar

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:77:
EXPECT_EQ(kBitrate, parsed.bitrate_bps());
check parsed.ssrcs() empty

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:80:
TEST(RtcpPacketRembTest, ParseFailsOnNonRembSmall) {
maybe ParseFailsOnTooSmallPacket

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:117: Remb remb;
maybe define kRemoteSsrc and use same in test

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:119:
std::vector<uint32_t> AlmostAll(kMax - 1, kRemoteSsrc[0]);
s/AlmostAll/almostAll

call allButOneSsrc?

check camel case

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:122:
std::vector<uint32_t> TwoMoreSsrcs(2, kRemoteSsrc[1]);
s/TwoMoreSsrcs/twoMoreSsrcs

[danilchap, 2016-01-20 16:13:19]

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc:107:
RTC_DCHECK_EQ(Psfb::media_ssrc(), 0u);
On 2016/01/20 15:33:13, åsapersson wrote:
> RTC_DCHECK_EQ(0u, ...

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h:53: static const uint32_t
kSignature = 0x52454D42;  // 'R' 'E' 'M' 'B'.
On 2016/01/20 15:33:13, åsapersson wrote:
> perhaps call kUniqueIdentifier (as in figure)

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h:59: uint32_t bitrate_;
On 2016/01/20 15:33:13, åsapersson wrote:
> call this bitrate_bps_?

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc (right):

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:28: const uint32_t
kRemoteSsrc[] = {0x23456789, 0x2345678a, 0x2345678b};
On 2016/01/20 15:33:13, åsapersson wrote:
> s/kRemoteSsrc/kRemoteSsrcs

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:67:
TEST(RtcpPacketRembTest, CreateAndParseEmpty) {
On 2016/01/20 15:33:13, åsapersson wrote:
> maybe CreateAndParseWithSsrcCountZero or similar

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:77:
EXPECT_EQ(kBitrate, parsed.bitrate_bps());
On 2016/01/20 15:33:13, åsapersson wrote:
> check parsed.ssrcs() empty

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:80:
TEST(RtcpPacketRembTest, ParseFailsOnNonRembSmall) {
On 2016/01/20 15:33:13, åsapersson wrote:
> maybe ParseFailsOnTooSmallPacket

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:117: Remb remb;
On 2016/01/20 15:33:13, åsapersson wrote:
> maybe define kRemoteSsrc and use same in test

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:119:
std::vector<uint32_t> AlmostAll(kMax - 1, kRemoteSsrc[0]);
On 2016/01/20 15:33:13, åsapersson wrote:
> s/AlmostAll/almostAll
> 
> call allButOneSsrc?
> 
> check camel case

Done.

https://codereview.webrtc.org/1552773002/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:122:
std::vector<uint32_t> TwoMoreSsrcs(2, kRemoteSsrc[1]);
On 2016/01/20 15:33:13, åsapersson wrote:
> s/TwoMoreSsrcs/twoMoreSsrcs

Done: handled same way as kAllButOneSsrc

[åsapersson, 2016-01-20 16:35:12]

lgtm

[danilchap, 2016-01-20 18:15:36]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-20 18:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552773002/60001

[commit-bot: I haz the power, 2016-01-20 20:08:55]

Description was changed from

==========
uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson
==========

[commit-bot: I haz the power, 2016-01-20 20:08:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-20 20:09:06]

Description was changed from

==========
uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
uses standard types instead of RTCPUtility type to store data.
got member read accessors, got Parse function.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/d8dccd57ea39ef7ce5f2fcb9b133be33fe1c6687
Cr-Commit-Position: refs/heads/master@{#11324}
==========

[commit-bot: I haz the power, 2016-01-20 20:09:07]

Patchset 4 (id:??) landed as
https://crrev.com/d8dccd57ea39ef7ce5f2fcb9b133be33fe1c6687
Cr-Commit-Position: refs/heads/master@{#11324}