Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1552563003: Use pointer to generated FEC packet. (Closed)

Created:
4 years, 12 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use pointer to generated FEC packet. Removes multiple index lookups to generated_fec_packets_ speeding up FecTest.FecTest with >2x in both Debug and Release, improving performance but also readability. On Debug this means that the slowest test in modules_tests now takes ~15-20 seconds instead of 50+ seconds, reducing the overall bottleneck. BUG=webrtc:4712 R=stefan@webrtc.org Committed: https://crrev.com/3886fc8f57770ade76fb4bca29474659fedc7609 Cr-Commit-Position: refs/heads/master@{#11166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 4 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pbos-webrtc
PTAL, locally this makes everything faster, but I don't think this is an actual hotspot ...
4 years, 12 months ago (2015-12-28 18:02:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552563003/1
4 years, 12 months ago (2015-12-28 18:10:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 19:19:28 UTC) #7
stefan-webrtc
lgtm
4 years, 11 months ago (2016-01-07 14:28:29 UTC) #8
pbos-webrtc
Committed patchset #1 (id:1) manually as 3886fc8f57770ade76fb4bca29474659fedc7609 (presubmit successful).
4 years, 11 months ago (2016-01-07 14:34:01 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:34:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3886fc8f57770ade76fb4bca29474659fedc7609
Cr-Commit-Position: refs/heads/master@{#11166}

Powered by Google App Engine
This is Rietveld 408576698