webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc - Issue 1551893002: [rtp_rtcp] rtcp::Sli packet moved into own file and got Parse function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

Issue 1551893002: [rtp_rtcp] rtcp::Sli packet moved into own file and got Parse function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

index 709a235bb37e4ffbf05674db0efaaaa81f41176c..dae45aff8d1e6229748ce239ea4e92a1ffb24859 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

@@ -25,6 +25,7 @@

#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h"

#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h"

#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"

+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h"

#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"

#include "webrtc/modules/rtp_rtcp/source/rtcp_receiver.h"

#include "webrtc/modules/rtp_rtcp/source/rtcp_sender.h"

@@ -566,7 +567,7 @@ TEST_F(RtcpReceiverTest, FirPacketNotToUsIgnored) {

TEST_F(RtcpReceiverTest, InjectSliPacket) {

rtcp::Sli sli;

- sli.WithPictureId(40);

+ sli.WithMacroblocks(40, 0, 1);

rtc::scoped_ptr<rtcp::RawPacket> packet(sli.Build());

EXPECT_EQ(0, InjectRtcpPacket(packet->Buffer(), packet->Length()));

EXPECT_EQ(kRtcpSli, rtcp_packet_info_.rtcpPacketTypeFlags);