webrtc/audio/audio_receive_stream.cc - Issue 1551813002: Storing raw audio sink for default audio track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/audio/audio_receive_stream.cc

Issue 1551813002: Storing raw audio sink for default audio track. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressing solenberg@'s comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/audio/audio_receive_stream.cc

diff --git a/webrtc/audio/audio_receive_stream.cc b/webrtc/audio/audio_receive_stream.cc

index dfad79f9d76420460267f2fdd0e1265a928b8786..1ed891fe5d542d2420d5e9bdd12f5fa568e6a796 100644

--- a/webrtc/audio/audio_receive_stream.cc

+++ b/webrtc/audio/audio_receive_stream.cc

@@ -203,9 +203,10 @@ webrtc::AudioReceiveStream::Stats AudioReceiveStream::GetStats() const {

return stats;

}

-void AudioReceiveStream::SetSink(rtc::scoped_ptr<AudioSinkInterface> sink) {

+void AudioReceiveStream::SetSink(

+ const rtc::scoped_refptr<AudioSinkInterface>& sink) {

RTC_DCHECK(thread_checker_.CalledOnValidThread());

- channel_proxy_->SetSink(std::move(sink));

+ channel_proxy_->SetSink(sink);

}

const webrtc::AudioReceiveStream::Config& AudioReceiveStream::config() const {