webrtc/voice_engine/channel_proxy.cc - Issue 1551813002: Storing raw audio sink for default audio track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel_proxy.cc

Issue 1551813002: Storing raw audio sink for default audio track. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding unit tests for SetRawAudioSink. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/voice_engine/channel_proxy.cc

diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc

index f54c81ec47265f0de194c09f60fa390f25679097..8e356bd82b8f73853f43069b720ceabc4286e233 100644

--- a/webrtc/voice_engine/channel_proxy.cc

+++ b/webrtc/voice_engine/channel_proxy.cc

@@ -139,9 +139,9 @@ bool ChannelProxy::SendTelephoneEventOutband(uint8_t event,

channel()->SendTelephoneEventOutband(event, duration_ms, 10, false) == 0;

}

-void ChannelProxy::SetSink(rtc::scoped_ptr<AudioSinkInterface> sink) {

+void ChannelProxy::SetSink(rtc::scoped_refptr<AudioSinkInterface> sink) {

RTC_DCHECK(thread_checker_.CalledOnValidThread());

- channel()->SetSink(std::move(sink));

+ channel()->SetSink(sink);

}

Channel* ChannelProxy::channel() const {