talk/app/webrtc/remoteaudiosource.cc - Issue 1551813002: Storing raw audio sink for default audio track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/remoteaudiosource.cc

Issue 1551813002: Storing raw audio sink for default audio track. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding unit tests for SetRawAudioSink. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/remoteaudiosource.cc

diff --git a/talk/app/webrtc/remoteaudiosource.cc b/talk/app/webrtc/remoteaudiosource.cc

index e904dd91925e48654832a5bb769f2e971c8b513e..45e2e9ec8af610ed4f40e2e4ffe1b3405641c7d0 100644

--- a/talk/app/webrtc/remoteaudiosource.cc

+++ b/talk/app/webrtc/remoteaudiosource.cc

@@ -96,8 +96,7 @@ void RemoteAudioSource::Initialize(uint32_t ssrc,

// To make sure we always get notified when the provider goes out of scope,

// we register for callbacks here and not on demand in AddSink.

if (provider) { // May be null in tests.

- provider->SetRawAudioSink(

- ssrc, rtc::scoped_ptr<AudioSinkInterface>(new Sink(this)));

+ provider->SetRawAudioSink(ssrc, new rtc::RefCountedObject<Sink>(this));

}