Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1551703002: Reland 1531763006 (Closed)

Created:
4 years, 11 months ago by guoweis_webrtc
Modified:
4 years, 11 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland 1531763006 Enable IPv6 temporary address filtering on iOS. We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes. BUG=webrtc:4343 Committed: https://crrev.com/29488c23644721c10a45eba74c67602b0262e582 Cr-Commit-Position: refs/heads/master@{#11114} patch from issue 1531763006 at patchset 200001 (http://crrev.com/1531763006#ps200001) TBR=pthatcher@webrtc.org Committed: https://crrev.com/9faf154960767e96afdf8a280a0a5c6c7e402f67 Cr-Commit-Position: refs/heads/master@{#11133}

Patch Set 1 #

Patch Set 2 : remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -50 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 3 chunks +7 lines, -0 lines 0 comments Download
A webrtc/base/ifaddrs_converter.h View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/base/ifaddrs_converter.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
A webrtc/base/macifaddrs_converter.cc View 1 chunk +281 lines, -0 lines 0 comments Download
M webrtc/base/network.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/network.cc View 5 chunks +38 lines, -43 lines 0 comments Download
M webrtc/base/network_unittest.cc View 6 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551703002/20001
4 years, 11 months ago (2015-12-28 20:59:08 UTC) #3
guoweis_webrtc
Committed patchset #2 (id:20001) manually as 9faf154960767e96afdf8a280a0a5c6c7e402f67 (presubmit successful).
4 years, 11 months ago (2015-12-28 22:07:09 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9faf154960767e96afdf8a280a0a5c6c7e402f67 Cr-Commit-Position: refs/heads/master@{#11133}
4 years, 11 months ago (2015-12-28 22:07:14 UTC) #7
Peter Kasting
This seems to break the Linux build when I attempt to roll into Chromium; see ...
4 years, 11 months ago (2016-01-09 10:37:04 UTC) #8
guidou
4 years, 11 months ago (2016-01-09 11:36:41 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1570443012/ by guidou@webrtc.org.

The reason for reverting is: This is preventing a webrtc roll into chromium.
See https://codereview.chromium.org/1572843002/.

Powered by Google App Engine
This is Rietveld 408576698