Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1550293003: [rtp_rtcp] rtcp::Rpsi cleaned and got Parse function (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Converting picture_id to bitstring pushed from WithPictureId to Create function. Added Parse and accessor functions. BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/44efbece6833980b56585d5b5e7b050b71cfc7e5 Cr-Commit-Position: refs/heads/master@{#11439}

Patch Set 1 #

Patch Set 2 : rebase & reclean #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -119 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h View 1 2 3 4 2 chunks +20 lines, -26 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc View 1 2 3 4 5 1 chunk +108 lines, -62 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi_unittest.cc View 1 2 3 4 5 chunks +133 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danilchap
4 years, 11 months ago (2016-01-22 13:03:48 UTC) #2
åsapersson
https://codereview.webrtc.org/1550293003/diff/80001/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc (right): https://codereview.webrtc.org/1550293003/diff/80001/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc#newcode79 webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc:79: LOG(LS_WARNING) << "Unknown rpsi packet with fractinal number of ...
4 years, 10 months ago (2016-01-29 15:46:01 UTC) #3
danilchap
https://codereview.webrtc.org/1550293003/diff/80001/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc (right): https://codereview.webrtc.org/1550293003/diff/80001/webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc#newcode79 webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc:79: LOG(LS_WARNING) << "Unknown rpsi packet with fractinal number of ...
4 years, 10 months ago (2016-01-29 16:53:25 UTC) #4
åsapersson
lgtm
4 years, 10 months ago (2016-02-01 08:36:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550293003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550293003/100001
4 years, 10 months ago (2016-02-01 09:12:01 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-01 09:36:41 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:36:49 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/44efbece6833980b56585d5b5e7b050b71cfc7e5
Cr-Commit-Position: refs/heads/master@{#11439}

Powered by Google App Engine
This is Rietveld 408576698