Change DTLS default from 1.0 to 1.2 for webrtc.

Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
R=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/a7446d2a50167602b04f58c917f5075ad5e494dc

[guoweis_webrtc, 2016-01-08 22:48:50]

guoweis@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[guoweis_webrtc, 2016-01-08 22:48:50]

PTAL.

[guoweis_webrtc, 2016-01-08 22:49:19]

Description was changed from

==========
Change DTLS default from 1.0 to 1.2

BUG=
==========

to

==========
Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
==========

[guoweis_webrtc, 2016-01-08 22:49:39]

guoweis@webrtc.org changed reviewers:
+ juberti@webrtc.org

[pthatcher1, 2016-01-08 23:07:50]

lgtm

Can you send out a PSA about it on webrtc-discuss?

[guoweis_webrtc, 2016-01-11 20:49:47]

guoweis@webrtc.org changed reviewers:
+ davidben@webrtc.org

[guoweis_webrtc, 2016-01-11 20:49:47]

davidben@, please review change in opensslstreamadapter.cc

[davidben_webrtc, 2016-01-11 21:10:55]

https://codereview.webrtc.org/1548733002/diff/20001/webrtc/base/opensslstream...
File webrtc/base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/1548733002/diff/20001/webrtc/base/opensslstream...
webrtc/base/opensslstreamadapter.cc:1152: }
Eh? Both of these functions will only ever return non-null or be a compile
error. That's not how this works. They morally should be constants but OpenSSL
historically had some problems exporting constants out of shared libraries on
some platforms.

As I said on https://codereview.webrtc.org/1550773002/, you should get rid of
these tests as they're really not helpful. They only serve to make things harder
for everyone when I make BoringSSL changes.

[guoweis_webrtc, 2016-01-11 21:50:36]

On 2016/01/11 21:10:55, davidben_webrtc wrote:
>
https://codereview.webrtc.org/1548733002/diff/20001/webrtc/base/opensslstream...
> File webrtc/base/opensslstreamadapter.cc (right):
> 
>
https://codereview.webrtc.org/1548733002/diff/20001/webrtc/base/opensslstream...
> webrtc/base/opensslstreamadapter.cc:1152: }
> Eh? Both of these functions will only ever return non-null or be a compile
> error. That's not how this works. They morally should be constants but OpenSSL
> historically had some problems exporting constants out of shared libraries on
> some platforms.
> 
> As I said on https://codereview.webrtc.org/1550773002/, you should get rid of
> these tests as they're really not helpful. They only serve to make things
harder
> for everyone when I make BoringSSL changes.

I see. I realized that now that I'm dealing with exactly the same issue as
https://bugs.chromium.org/p/webrtc/issues/detail?id=5381. In that case, I'll
disable these tests in the same way for MSAN build and let 5381 to deal with
them all together.

[guoweis_webrtc, 2016-01-11 22:10:05]

Patchset #3 (id:40001) has been deleted

[guoweis_webrtc, 2016-01-11 22:25:48]

The CQ bit was checked by guoweis@webrtc.org

[guoweis_webrtc, 2016-01-11 22:25:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1548733002/#ps60001 (title:
"disable tests which fail under msan build. See webrtc bug 5381")

[commit-bot: I haz the power, 2016-01-11 22:25:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1548733002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1548733002/60001

[commit-bot: I haz the power, 2016-01-11 23:27:15]

Description was changed from

==========
Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
==========

to

==========
Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/a7446d2a50167602b04f58c917f5075ad5e494dc
Cr-Commit-Position: refs/heads/master@{#11211}
==========

[commit-bot: I haz the power, 2016-01-11 23:27:16]

Patchset 3 (id:??) landed as
https://crrev.com/a7446d2a50167602b04f58c917f5075ad5e494dc
Cr-Commit-Position: refs/heads/master@{#11211}

[guoweis_webrtc, 2016-01-11 23:27:16]

Description was changed from

==========
Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/a7446d2a50167602b04f58c917f5075ad5e494dc
Cr-Commit-Position: refs/heads/master@{#11211}
==========

to

==========
Change DTLS default from 1.0 to 1.2 for webrtc.

This changes for standalone webrtc applications.

BUG=
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a7446d2a50167602b04f58c91...
==========

[guoweis_webrtc, 2016-01-11 23:27:17]

Committed patchset #3 (id:60001) manually as
a7446d2a50167602b04f58c917f5075ad5e494dc (presubmit successful).