Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1548373002: Roll gtest-parallel. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll gtest-parallel. Brings in fix that prevents disabled parameterized tests from running by default. BUG=webrtc:5280 TBR=kjellander@webrtc.org Committed: https://crrev.com/6d3f11c36604c124e0ab79c37921464e7dd7dfe7 Cr-Commit-Position: refs/heads/master@{#11132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/gtest-parallel/README.webrtc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gtest-parallel/gtest-parallel View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548373002/1
4 years, 11 months ago (2015-12-28 20:14:25 UTC) #2
pbos-webrtc
PTAL, pushing this in since it's breaking bots.
4 years, 11 months ago (2015-12-28 20:14:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 21:11:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d3f11c36604c124e0ab79c37921464e7dd7dfe7 Cr-Commit-Position: refs/heads/master@{#11132}
4 years, 11 months ago (2015-12-28 21:11:18 UTC) #6
kjellander_webrtc
4 years, 11 months ago (2016-01-04 12:55:58 UTC) #7
Message was sent while issue was closed.
lgtm. You should consider adding a simple test for this script, at least for the
list-tests part since it contains a bit of logic handling different cases.

Powered by Google App Engine
This is Rietveld 408576698