Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1548263003: Use getExternalStorageDirectory() for trace file. (Closed)

Created:
4 years, 12 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use getExternalStorageDirectory() for trace file. Removes hard-coded /mnt/sdcard/ path. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/41d1a62d43634dbe781d7aec2fb319bfa7a01045 Cr-Commit-Position: refs/heads/master@{#11142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
pbos-webrtc
PTAL
4 years, 12 months ago (2015-12-28 23:46:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548263003/1
4 years, 12 months ago (2015-12-28 23:51:03 UTC) #3
AlexG
lgtm
4 years, 12 months ago (2015-12-28 23:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548263003/1
4 years, 12 months ago (2015-12-28 23:53:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 12 months ago (2015-12-29 01:51:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548263003/1
4 years, 11 months ago (2015-12-30 16:25:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 17:23:34 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 17:23:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d1a62d43634dbe781d7aec2fb319bfa7a01045
Cr-Commit-Position: refs/heads/master@{#11142}

Powered by Google App Engine
This is Rietveld 408576698