Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: webrtc/p2p/base/turnport_unittest.cc

Issue 1547373002: Cease all future TURN requests when a TURN refresh request fails. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Fix a test issue Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/turnport.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/turnport_unittest.cc
diff --git a/webrtc/p2p/base/turnport_unittest.cc b/webrtc/p2p/base/turnport_unittest.cc
index 57207486f8c94cdc36f510f661aa1d9430522099..9ed35ed92ff2b1d8ad9e8167700becfabe35c2f7 100644
--- a/webrtc/p2p/base/turnport_unittest.cc
+++ b/webrtc/p2p/base/turnport_unittest.cc
@@ -707,8 +707,7 @@ TEST_F(TurnPortTest, TestRefreshRequestGetsErrorResponse) {
// Flush it again, it will receive a bad response.
turn_port_->FlushRequests();
EXPECT_TRUE_WAIT(!turn_refresh_success_, kTimeout);
- EXPECT_TRUE(turn_port_->connections().empty());
pthatcher1 2015/12/30 22:52:13 Shouldn't we still check this?
honghaiz3 2015/12/31 03:22:10 It wasn't needed because we did not create connect
- EXPECT_FALSE(turn_port_->connected());
+ EXPECT_TRUE_WAIT(!turn_port_->connected(), kTimeout);
}
// Test that CreateConnection will return null if port becomes disconnected.
« no previous file with comments | « webrtc/p2p/base/turnport.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698