Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

Issue 1547343002: Remove DISABLED_ON_ macros. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: win compile Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
index d4e1e6e3a06bb2096d51c449bcf8bb162d2de3ee..607e5ebf0f80163695f53567b9910efe96bb559e 100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
@@ -22,7 +22,6 @@
#include "webrtc/test/testsupport/fileutils.h"
#include "webrtc/test/testsupport/frame_reader.h"
#include "webrtc/test/testsupport/frame_writer.h"
-#include "webrtc/test/testsupport/gtest_disable.h"
#include "webrtc/test/testsupport/metrics/video_metrics.h"
#include "webrtc/test/testsupport/packet_reader.h"
#include "webrtc/typedefs.h"
@@ -815,7 +814,11 @@ TEST_F(VideoProcessorIntegrationTest, Process10PercentPacketLoss) {
// target rate/per-frame bandwidth (for each rate update) is within limits.
// One key frame (first frame only) in sequence.
TEST_F(VideoProcessorIntegrationTest,
- DISABLED_ON_ANDROID(ProcessNoLossChangeBitRateVP8)) {
+#if defined(WEBRTC_ANDROID)
kjellander_webrtc 2016/01/04 12:52:45 Please use the MAYBE_ pattern as described on http
pbos-webrtc 2016/01/04 13:01:27 Inlined TEST_F instead for readability (imo)
kjellander_webrtc 2016/01/04 14:59:06 I don't like us having different ways of doing thi
pbos-webrtc 2016/01/04 16:11:42 Done.
+ DISABLED_ProcessNoLossChangeBitRateVP8) {
+#else
+ ProcessNoLossChangeBitRateVP8) {
+#endif
// Bitrate and frame rate profile.
RateProfile rate_profile;
SetRateProfilePars(&rate_profile, 0, 200, 30, 0);
@@ -847,7 +850,11 @@ TEST_F(VideoProcessorIntegrationTest,
// Note: quality after update should be higher but we currently compute quality
// metrics averaged over whole sequence run.
TEST_F(VideoProcessorIntegrationTest,
- DISABLED_ON_ANDROID(ProcessNoLossChangeFrameRateFrameDropVP8)) {
+#if defined(WEBRTC_ANDROID)
+ DISABLED_ProcessNoLossChangeFrameRateFrameDropVP8) {
+#else
+ ProcessNoLossChangeFrameRateFrameDropVP8) {
+#endif
config_.networking_config.packet_loss_probability = 0;
// Bitrate and frame rate profile.
RateProfile rate_profile;
@@ -875,7 +882,11 @@ TEST_F(VideoProcessorIntegrationTest,
// Run with no packet loss, at low bitrate. During this time we should've
// resized once. Expect 2 key frames generated (first and one for resize).
TEST_F(VideoProcessorIntegrationTest,
- DISABLED_ON_ANDROID(ProcessNoLossSpatialResizeFrameDropVP8)) {
+#if defined(WEBRTC_ANDROID)
+ DISABLED_ProcessNoLossSpatialResizeFrameDropVP8) {
+#else
+ ProcessNoLossSpatialResizeFrameDropVP8) {
+#endif
config_.networking_config.packet_loss_probability = 0;
// Bitrate and frame rate profile.
RateProfile rate_profile;
@@ -902,7 +913,11 @@ TEST_F(VideoProcessorIntegrationTest,
// No dropped frames in this test, and internal spatial resizer is off.
// One key frame (first frame only) in sequence, so no spatial resizing.
TEST_F(VideoProcessorIntegrationTest,
- DISABLED_ON_ANDROID(ProcessNoLossTemporalLayersVP8)) {
+#if defined(WEBRTC_ANDROID)
+ DISABLED_ProcessNoLossTemporalLayersVP8) {
+#else
+ ProcessNoLossTemporalLayersVP8) {
+#endif
config_.networking_config.packet_loss_probability = 0;
// Bitrate and frame rate profile.
RateProfile rate_profile;

Powered by Google App Engine
This is Rietveld 408576698