Remove DISABLED_ON_ macros.

Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73

[pbos-webrtc, 2015-12-28 21:24:18]

disable NetEqStereoTestLosses on all platforms

[pbos-webrtc, 2015-12-28 21:24:56]

Description was changed from

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5280
R=henrik.lundin@webrtc.org, kjellander@webrtc.org
==========

to

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387
R=henrik.lundin@webrtc.org, kjellander@webrtc.org
==========

[pbos-webrtc, 2015-12-28 21:28:33]

PTAL, this foot-shooting gun needs to go.

kjellander@: Please review in general.

henrik.lundin@: I found it more suiting to not build certain tests when we're
sure they'll fail (instead of disabling them), so take a look at audio_coding
specifically. Also I had to disable MultiChannel/NetEqStereoTestLosses.RunTest
everywhere (as it effectively already is), since it's failing currently.

Before this change:

MultiChannel/NetEqStereoTestNoJitter.
  DISABLED_ON_ANDROID(RunTest)/0  # GetParam() = {frame_size = 10, num_channels
= 2, sample_rate = 8000}
  DISABLED_ON_ANDROID(RunTest)/1  # GetParam() = {frame_size = 10, num_channels
= 5, sample_rate = 8000}
  ..
MultiChannel/NetEqStereoTestPositiveDrift.
  DISABLED_ON_ANDROID(RunTest)/0  # GetParam() = {frame_size = 10, num_channels
= 2, sample_rate = 8000}
  DISABLED_ON_ANDROID(RunTest)/1  # GetParam() = {frame_size = 10, num_channels
= 5, sample_rate = 8000}
  ..
MultiChannel/NetEqStereoTestNegativeDrift.
  DISABLED_ON_ANDROID(RunTest)/0  # GetParam() = {frame_size = 10, num_channels
= 2, sample_rate = 8000}
  DISABLED_ON_ANDROID(RunTest)/1  # GetParam() = {frame_size = 10, num_channels
= 5, sample_rate = 8000}
  ..
MultiChannel/NetEqStereoTestDelays.
  DISABLED_ON_ANDROID(RunTest)/0  # GetParam() = {frame_size = 10, num_channels
= 2, sample_rate = 8000}
  DISABLED_ON_ANDROID(RunTest)/1  # GetParam() = {frame_size = 10, num_channels
= 5, sample_rate = 8000}
  ..
MultiChannel/NetEqStereoTestLosses.
  DISABLED_ON_ANDROID(RunTest)/0  # GetParam() = {frame_size = 10, num_channels
= 2, sample_rate = 8000}
  DISABLED_ON_ANDROID(RunTest)/1  # GetParam() = {frame_size = 10, num_channels
= 5, sample_rate = 8000}
  ..

After only NetEqStereoTestLosses is disabled among these, which improves overall
test coverage.

[pbos-webrtc, 2015-12-28 21:28:44]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-28 21:29:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547343002/20001

[commit-bot: I haz the power, 2015-12-28 22:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 22:32:47]

Dry run: Exceeded global retry quota

[pbos-webrtc, 2015-12-29 00:02:54]

win compile

[pbos-webrtc, 2015-12-29 00:06:09]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-29 00:06:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547343002/40001

[commit-bot: I haz the power, 2015-12-29 00:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-29 00:10:17]

Dry run: Try jobs failed on following builders:
  win_drmemory_light on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)

[kjellander_webrtc, 2016-01-04 12:52:45]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[kjellander_webrtc, 2016-01-04 12:52:45]

Please use the MAYBE_ pattern as described on
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha....

Adding phoglund as the original author of gtest_disable.h

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:817:
#if defined(WEBRTC_ANDROID)
Please use the MAYBE_ pattern as described on
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha...
since Windows doesn't understand this style.

[pbos-webrtc, 2016-01-04 12:59:08]

move test_f for windows

[pbos-webrtc, 2016-01-04 13:01:21]

disable testredefec on android again

[pbos-webrtc, 2016-01-04 13:01:27]

PTAL

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:817:
#if defined(WEBRTC_ANDROID)
On 2016/01/04 12:52:45, kjellander (webrtc) wrote:
> Please use the MAYBE_ pattern as described on
>
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha...
> since Windows doesn't understand this style.

Inlined TEST_F instead for readability (imo)

[pbos-webrtc, 2016-01-04 13:01:35]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 13:01:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547343002/80001

[commit-bot: I haz the power, 2016-01-04 13:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 13:33:09]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9015)

[pbos-webrtc, 2016-01-04 13:53:56]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 13:54:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547343002/80001

[phoglund, 2016-01-04 14:01:55]

lgtm

[commit-bot: I haz the power, 2016-01-04 14:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 14:13:55]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-01-04 14:59:07]

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:817:
#if defined(WEBRTC_ANDROID)
On 2016/01/04 13:01:27, pbos-webrtc wrote:
> On 2016/01/04 12:52:45, kjellander (webrtc) wrote:
> > Please use the MAYBE_ pattern as described on
> >
>
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha...
> > since Windows doesn't understand this style.
> 
> Inlined TEST_F instead for readability (imo)

I don't like us having different ways of doing this as the code will diverge
over time. Please follow the established pattern instead, even if you think it's
more readable (I'm sure there's a good reason for the MAYBE_ style).
Unless you're signing up for changing the all the existing MAYBE_ entries we
have + writing a new wiki page with guidelines on how to do this?

[pbos-webrtc, 2016-01-04 16:11:07]

MAYBE_ yo

[pbos-webrtc, 2016-01-04 16:11:42]

Converted all back that I could find, PTAL

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/1547343002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:817:
#if defined(WEBRTC_ANDROID)
On 2016/01/04 14:59:06, kjellander (webrtc) wrote:
> On 2016/01/04 13:01:27, pbos-webrtc wrote:
> > On 2016/01/04 12:52:45, kjellander (webrtc) wrote:
> > > Please use the MAYBE_ pattern as described on
> > >
> >
>
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha...
> > > since Windows doesn't understand this style.
> > 
> > Inlined TEST_F instead for readability (imo)
> 
> I don't like us having different ways of doing this as the code will diverge
> over time. Please follow the established pattern instead, even if you think
it's
> more readable (I'm sure there's a good reason for the MAYBE_ style).
> Unless you're signing up for changing the all the existing MAYBE_ entries we
> have + writing a new wiki page with guidelines on how to do this?

Done.

[pbos-webrtc, 2016-01-04 16:11:53]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 16:11:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547343002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547343002/100001

[commit-bot: I haz the power, 2016-01-04 17:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 17:56:15]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-01-04 19:38:10]

Looks great. Thanks a bunch for taking the time to do all these tedious changes!
LGTM!

[pbos-webrtc, 2016-01-04 21:40:38]

Description was changed from

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387
R=henrik.lundin@webrtc.org, kjellander@webrtc.org
==========

to

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
==========

[pbos-webrtc, 2016-01-04 21:43:06]

Description was changed from

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
==========

to

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
==========

[pbos-webrtc, 2016-01-04 21:43:31]

TBR=henrik.lundin@ who I've assigned the re-enabling to.

[commit-bot: I haz the power, 2016-01-04 21:44:21]

Description was changed from

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
==========

to

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org

Committed: https://crrev.com/e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73
Cr-Commit-Position: refs/heads/master@{#11150}
==========

[commit-bot: I haz the power, 2016-01-04 21:44:22]

Patchset 6 (id:??) landed as
https://crrev.com/e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73
Cr-Commit-Position: refs/heads/master@{#11150}

[pbos-webrtc, 2016-01-04 21:44:29]

Description was changed from

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org

Committed: https://crrev.com/e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73
Cr-Commit-Position: refs/heads/master@{#11150}
==========

to

==========
Remove DISABLED_ON_ macros.

Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.

This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.

The change also removes gtest_disable.h as an unused include from many
other files.

BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e2976c87f7ba627fa1e1246f0...
==========

[pbos-webrtc, 2016-01-04 21:44:30]

Committed patchset #6 (id:100001) manually as
e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73 (presubmit successful).

[hlundin-webrtc, 2016-01-08 13:46:45]

webrtc/modules/audio_*: lgtm