Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545393003: Update API for Objective-C RTCDataChannel. (Closed)

Created:
4 years, 11 months ago by hjon
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update API for Objective-C RTCDataChannel. BUG= Committed: https://crrev.com/e373dc20c4f6446dedfd885724032de1a10d8e39 Cr-Commit-Position: refs/heads/master@{#11362}

Patch Set 1 #

Patch Set 2 : Minor updates #

Patch Set 3 : Changes based on other CL feedback #

Patch Set 4 : Update against master #

Total comments: 14

Patch Set 5 : Update against master #

Patch Set 6 : Changes from feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -0 lines) Patch
M webrtc/api/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCDataChannel.h View 1 2 3 4 5 1 chunk +120 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCDataChannel.mm View 1 2 3 4 5 1 chunk +221 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCDataChannel+Private.h View 1 2 3 4 5 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hjon
4 years, 11 months ago (2015-12-31 00:00:34 UTC) #2
hjon
4 years, 11 months ago (2016-01-06 17:13:42 UTC) #3
tkchin_webrtc
https://codereview.webrtc.org/1545393003/diff/60001/webrtc/api/objc/RTCDataChannel+Private.h File webrtc/api/objc/RTCDataChannel+Private.h (right): https://codereview.webrtc.org/1545393003/diff/60001/webrtc/api/objc/RTCDataChannel+Private.h#newcode24 webrtc/api/objc/RTCDataChannel+Private.h:24: @property(nonatomic, readonly) const webrtc::DataBuffer* nativeDataBuffer; space * https://codereview.webrtc.org/1545393003/diff/60001/webrtc/api/objc/RTCDataChannel.mm File ...
4 years, 11 months ago (2016-01-22 00:04:26 UTC) #4
hjon
https://codereview.webrtc.org/1545393003/diff/60001/webrtc/api/objc/RTCDataChannel+Private.h File webrtc/api/objc/RTCDataChannel+Private.h (right): https://codereview.webrtc.org/1545393003/diff/60001/webrtc/api/objc/RTCDataChannel+Private.h#newcode24 webrtc/api/objc/RTCDataChannel+Private.h:24: @property(nonatomic, readonly) const webrtc::DataBuffer* nativeDataBuffer; On 2016/01/22 00:04:26, tkchin_webrtc ...
4 years, 11 months ago (2016-01-22 17:57:48 UTC) #5
tkchin_webrtc
lgtm
4 years, 11 months ago (2016-01-22 21:04:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545393003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545393003/100001
4 years, 11 months ago (2016-01-22 21:04:10 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-22 22:04:31 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 22:04:40 UTC) #11
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/e373dc20c4f6446dedfd885724032de1a10d8e39
Cr-Commit-Position: refs/heads/master@{#11362}

Powered by Google App Engine
This is Rietveld 408576698