[rtp_rtcp] rtcp::SenderReport moved into own file and got Parse function

webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc

+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+using webrtc::rtcp::RawPacket;
+using webrtc::rtcp::ReportBlock;
+using webrtc::rtcp::SenderReport;
+
+namespace webrtc {
+
+class RtcpPacketSenderReportTest : public ::testing::Test {
+ protected:
+  const uint32_t kSenderSsrc = 0x12345678;
+  const uint32_t kRemoteSsrc = 0x23456789;
+
+  void BuildPacket() { packet = sr.Build(); }
+  void ParsePacket() {
+    using RTCPUtility::RtcpCommonHeader;
+    using RTCPUtility::RtcpParseCommonHeader;

[åsapersson, 2016/01/13 14:11:32]

move above?

[danilchap, 2016/01/13 15:54:44]

Done.

+    RtcpCommonHeader header;
+    EXPECT_TRUE(
+        RtcpParseCommonHeader(packet->Buffer(), packet->Length(), &header));
+    EXPECT_EQ(packet->Length(), header.BlockSize());
+    EXPECT_TRUE(SenderReport::kPacketType == header.packet_type);

[åsapersson, 2016/01/13 14:11:32]

remove, already checked in Parse?

[danilchap, 2016/01/13 15:54:44]

Done.

+    EXPECT_TRUE(parsed_.Parse(
+        header, packet->Buffer() + RtcpCommonHeader::kHeaderSizeBytes));
+  }
+
+  SenderReport sr;

[åsapersson, 2016/01/13 14:11:32]

end with underscore?

[danilchap, 2016/01/13 15:54:44]

tests access this variable directly, as if it is a local variable.
So I guess would be better to make it local.

+  rtc::scoped_ptr<RawPacket> packet;
+  // only ParsePacket can change parsed, tests should use it in ro mode

[åsapersson, 2016/01/13 14:11:32]

s/only/Only (end w/period).

[danilchap, 2016/01/13 15:54:44]

Done.

+  const SenderReport& parsed() { return parsed_; }
+
+ private:
+  SenderReport parsed_;
+};
+
+TEST_F(RtcpPacketSenderReportTest, SenderReport) {

[åsapersson, 2016/01/13 14:11:32]

maybe call WithNoReportBlock

[danilchap, 2016/01/13 15:54:44]

Done, WithoutReportBlocks feels even better. 

+  sr.From(kSenderSsrc);
+  sr.WithNtp(NtpTime(0x11121418, 0x22242628));

[åsapersson, 2016/01/13 14:11:32]

use constants for these and below?

[danilchap, 2016/01/13 15:54:44]

Done.

+  sr.WithRtpTimestamp(0x33343536);
+  sr.WithPacketCount(0x44454647);
+  sr.WithOctetCount(0x55565758);
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(kSenderSsrc, parsed().sender_ssrc());
+  EXPECT_EQ(0x11121418U, parsed().ntp().seconds());
+  EXPECT_EQ(0x22242628U, parsed().ntp().fractions());
+  EXPECT_EQ(0x33343536U, parsed().rtp_timestamp());
+  EXPECT_EQ(0x44454647U, parsed().sender_packet_count());
+  EXPECT_EQ(0x55565758U, parsed().sender_octet_count());
+  EXPECT_TRUE(parsed().report_blocks().empty());
+}
+
+TEST_F(RtcpPacketSenderReportTest, WithOneReportBlock) {
+  ReportBlock rb;
+  rb.To(kRemoteSsrc);
+
+  sr.From(kSenderSsrc);
+  EXPECT_TRUE(sr.WithReportBlock(rb));
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(kSenderSsrc, parsed().sender_ssrc());
+  EXPECT_EQ(1u, parsed().report_blocks().size());
+  EXPECT_EQ(kRemoteSsrc, parsed().report_blocks()[0].source_ssrc());
+}
+
+TEST_F(RtcpPacketSenderReportTest, WithTwoReportBlocks) {
+  ReportBlock rb1;
+  rb1.To(kRemoteSsrc);
+  ReportBlock rb2;
+  rb2.To(kRemoteSsrc + 1);
+
+  sr.From(kSenderSsrc);
+  EXPECT_TRUE(sr.WithReportBlock(rb1));
+  EXPECT_TRUE(sr.WithReportBlock(rb2));
+
+  BuildPacket();
+  ParsePacket();
+
+  EXPECT_EQ(kSenderSsrc, parsed().sender_ssrc());
+  EXPECT_EQ(2u, parsed().report_blocks().size());
+  EXPECT_EQ(kRemoteSsrc, parsed().report_blocks()[0].source_ssrc());
+  EXPECT_EQ(kRemoteSsrc + 1, parsed().report_blocks()[1].source_ssrc());
+}
+
+TEST_F(RtcpPacketSenderReportTest, WithTooManyReportBlocks) {
+  sr.From(kSenderSsrc);
+  const size_t kMaxReportBlocks = (1 << 5) - 1;
+  ReportBlock rb;
+  for (size_t i = 0; i < kMaxReportBlocks; ++i) {
+    rb.To(kRemoteSsrc + i);
+    EXPECT_TRUE(sr.WithReportBlock(rb));
+  }
+  rb.To(kRemoteSsrc + kMaxReportBlocks);
+  EXPECT_FALSE(sr.WithReportBlock(rb));
+}
+
+}  // namespace webrtc