webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc - Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

index d239d85d6c4d72c6e398bc52c42f6f2a9c1f1a3d..7ec10bdb29f769f58cd1399f33d5d38c4bb1863c 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

@@ -552,7 +552,7 @@ TEST_F(RtcpReceiverTest, InjectFirPacket) {

rtcp_receiver_->SetSsrcs(kSourceSsrc, ssrcs);

rtcp::Fir fir;

- fir.To(kSourceSsrc);

+ fir.WithRequestTo(kSourceSsrc, 13);

rtc::scoped_ptr<rtcp::RawPacket> packet(fir.Build());

EXPECT_EQ(0, InjectRtcpPacket(packet->Buffer(), packet->Length()));

EXPECT_EQ(kRtcpFir, rtcp_packet_info_.rtcpPacketTypeFlags);

@@ -565,7 +565,7 @@ TEST_F(RtcpReceiverTest, FirPacketNotToUsIgnored) {

rtcp_receiver_->SetSsrcs(kSourceSsrc, ssrcs);

rtcp::Fir fir;

- fir.To(kSourceSsrc + 1);

+ fir.WithRequestTo(kSourceSsrc + 1, 13);

rtc::scoped_ptr<rtcp::RawPacket> packet(fir.Build());

EXPECT_EQ(0, InjectRtcpPacket(packet->Buffer(), packet->Length()));

EXPECT_EQ(0U, rtcp_packet_info_.rtcpPacketTypeFlags);