webrtc/modules/rtp_rtcp/source/rtcp_packet.h - Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

index 965a667304a8ebc02ab57fc0b455e2d6601f8298..78f06ebb2f6da860a2726b84d33cff110fc8fda9 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

@@ -38,8 +38,7 @@ class RawPacket;

// Fir fir;

// fir.From(123);

-// fir.To(234)

-// fir.WithCommandSeqNum(123);

+// fir.WithRequestTo(234, 123);

åsapersson 2016/01/21 16:04:35 maybe change sequence number 123 to something else

danilchap 2016/01/21 16:48:12 Done.

// size_t length = 0; // Builds an intra frame request

// uint8_t packet[kPacketSize]; // with sequence number 123.

« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h » ('J')