webrtc/modules/rtp_rtcp/source/rtcp_sender.cc - Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

Issue 1544403002: [rtp_rtcp] rtcp::Fir cleaned and got Parse function. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

index 4b0914d47d290eed663e4c4b37a867a7c209a115..321741eef7ec8b915481bd411c6692649d9a6b16 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

@@ -541,8 +541,7 @@ rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildFIR(const RtcpContext& ctx) {

rtcp::Fir* fir = new rtcp::Fir();

fir->From(ssrc_);

- fir->To(remote_ssrc_);

- fir->WithCommandSeqNum(sequence_number_fir_);

+ fir->WithRequestTo(remote_ssrc_, sequence_number_fir_);

TRACE_EVENT_INSTANT0(TRACE_DISABLED_BY_DEFAULT("webrtc_rtp"),

"RTCPSender::FIR");

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc ('k') | no next file » | no next file with comments »