Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1543933004: Fix for stats updated twice when switching content type. (Closed)

Created:
5 years ago by åsapersson
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for stats updated twice when switching content type (realtime <-> screenshare). Add unittest. BUG= Committed: https://crrev.com/59bac1a4c557bb4ba4e5f9f2f6db6040ae4b41a7 Cr-Commit-Position: refs/heads/master@{#11180}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M webrtc/video/send_statistics_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
åsapersson
4 years, 11 months ago (2016-01-07 14:24:37 UTC) #4
pbos-webrtc
lgtm
4 years, 11 months ago (2016-01-07 14:29:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543933004/60001
4 years, 11 months ago (2016-01-08 07:32:15 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-08 07:36:04 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 07:36:10 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/59bac1a4c557bb4ba4e5f9f2f6db6040ae4b41a7
Cr-Commit-Position: refs/heads/master@{#11180}

Powered by Google App Engine
This is Rietveld 408576698