Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webrtc/video/video_send_stream_tests.cc

Issue 1541923003: Disable VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> // max 10 #include <algorithm> // max
(...skipping 1634 matching lines...) Expand 10 before | Expand all | Expand 10 after
1645 1645
1646 void PerformTest() override { 1646 void PerformTest() override {
1647 EXPECT_TRUE(Wait()) 1647 EXPECT_TRUE(Wait())
1648 << "Timed out while waiting for the encoder to be initialized."; 1648 << "Timed out while waiting for the encoder to be initialized.";
1649 } 1649 }
1650 } test; 1650 } test;
1651 1651
1652 RunBaseTest(&test, FakeNetworkPipe::Config()); 1652 RunBaseTest(&test, FakeNetworkPipe::Config());
1653 } 1653 }
1654 1654
1655 TEST_F(VideoSendStreamTest, ReconfigureBitratesSetsEncoderBitratesCorrectly) { 1655 // Disabled on LinuxAsan:
1656 // https://bugs.chromium.org/p/webrtc/issues/detail?id=5382
1657 #if defined(ADDRESS_SANITIZER) && defined(WEBRTC_LINUX)
1658 #define MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly \
1659 DISABLED_ReconfigureBitratesSetsEncoderBitratesCorrectly
1660 #else
1661 #define MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly \
1662 ReconfigureBitratesSetsEncoderBitratesCorrectly
1663 #endif
1664
1665 TEST_F(VideoSendStreamTest,
1666 MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly) {
1656 // These are chosen to be "kind of odd" to not be accidentally checked against 1667 // These are chosen to be "kind of odd" to not be accidentally checked against
1657 // default values. 1668 // default values.
1658 static const int kMinBitrateKbps = 137; 1669 static const int kMinBitrateKbps = 137;
1659 static const int kStartBitrateKbps = 345; 1670 static const int kStartBitrateKbps = 345;
1660 static const int kLowerMaxBitrateKbps = 312; 1671 static const int kLowerMaxBitrateKbps = 312;
1661 static const int kMaxBitrateKbps = 413; 1672 static const int kMaxBitrateKbps = 413;
1662 static const int kIncreasedStartBitrateKbps = 451; 1673 static const int kIncreasedStartBitrateKbps = 451;
1663 static const int kIncreasedMaxBitrateKbps = 597; 1674 static const int kIncreasedMaxBitrateKbps = 597;
1664 class EncoderBitrateThresholdObserver : public test::SendTest, 1675 class EncoderBitrateThresholdObserver : public test::SendTest,
1665 public test::FakeEncoder { 1676 public test::FakeEncoder {
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
2214 EXPECT_GT(vp9_header.num_ref_pics, 0u); 2225 EXPECT_GT(vp9_header.num_ref_pics, 0u);
2215 observation_complete_.Set(); 2226 observation_complete_.Set();
2216 } 2227 }
2217 } 2228 }
2218 } test; 2229 } test;
2219 2230
2220 RunBaseTest(&test, FakeNetworkPipe::Config()); 2231 RunBaseTest(&test, FakeNetworkPipe::Config());
2221 } 2232 }
2222 2233
2223 } // namespace webrtc 2234 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698