Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1541633002: Reland "Added option to specify a maximum file size when recording an AEC dump." (Closed)

Created:
5 years ago by ivoc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87. The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4. Original review: https://codereview.webrtc.org/1413483003/ The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function. NOTRY=true TBR=glaznev@webrtc.org, henrik.lundin@webrtc.org, solenberg@google.com, henrikg@webrtc.org, perkj@webrtc.org BUG=webrtc:4741 Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a Cr-Commit-Position: refs/heads/master@{#11093}

Patch Set 1 : Original CL. #

Patch Set 2 : Fix to prevent Chrome from breaking. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -60 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +4 lines, -3 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +5 lines, -3 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 chunk +3 lines, -1 line 0 comments Download
M talk/media/base/mediaengine.h View 2 chunks +6 lines, -4 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +5 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 chunk +4 lines, -2 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 3 chunks +7 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 13 chunks +28 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 1 chunk +12 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 9 chunks +34 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541633002/20001
5 years ago (2015-12-19 18:01:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-19 18:02:35 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a Cr-Commit-Position: refs/heads/master@{#11093}
5 years ago (2015-12-19 18:02:46 UTC) #16
ivoc
5 years ago (2015-12-19 18:14:01 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1537213002/ by ivoc@webrtc.org.

The reason for reverting is: Compile error on Android needs to be fixed before
relanding.  .

Powered by Google App Engine
This is Rietveld 408576698