Update API for Objective-C RTCStats.

Update API for Objective-C RTCStats.

BUG=
R=tkchin@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/a2c353f81571fa32ae008d74583e4ac32fa700df

[hjon, 2015-12-20 23:21:00]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2015-12-21 12:57:13]

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats+Priv...
File webrtc/api/objc/RTCStats+Private.h (right):

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats+Priv...
webrtc/api/objc/RTCStats+Private.h:21: * ownership is taken of the native stats
report.
nit: don't need ownership comment, since it's pass by reference

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm
File webrtc/api/objc/RTCStats.mm (right):

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm#n...
webrtc/api/objc/RTCStats.mm:42: for (auto const &it : stats.values()) {
nit: auto const &valuePair : stats.values()
it's a stdpair not an iterator

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm#n...
webrtc/api/objc/RTCStats.mm:47: _values = values;
suggest turning this into an immutable NSDictionary for safety

[hjon, 2015-12-21 22:02:53]

From a little research, it looks like a const reference cannot be NULL; is that
correct such that NSParameterAssert isn't needed?

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats+Priv...
File webrtc/api/objc/RTCStats+Private.h (right):

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats+Priv...
webrtc/api/objc/RTCStats+Private.h:21: * ownership is taken of the native stats
report.
On 2015/12/21 12:57:13, tkchin_webrtc wrote:
> nit: don't need ownership comment, since it's pass by reference

Done.

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm
File webrtc/api/objc/RTCStats.mm (right):

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm#n...
webrtc/api/objc/RTCStats.mm:42: for (auto const &it : stats.values()) {
On 2015/12/21 12:57:13, tkchin_webrtc wrote:
> nit: auto const &valuePair : stats.values()
> it's a stdpair not an iterator

Done.

https://codereview.webrtc.org/1540113002/diff/1/webrtc/api/objc/RTCStats.mm#n...
webrtc/api/objc/RTCStats.mm:47: _values = values;
On 2015/12/21 12:57:13, tkchin_webrtc wrote:
> suggest turning this into an immutable NSDictionary for safety

Done.

[tkchin_webrtc, 2016-01-05 20:08:17]

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats.h
File webrtc/api/objc/RTCStats.h (right):

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.h:19: //** Time since 1970-01-01T00:00:00Z in
milliseconds. */
/** not //**

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.h:26: @property(nonatomic, readonly) NSString *id;
statsId

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats.mm
File webrtc/api/objc/RTCStats.mm (right):

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.mm:46: values[key] = value;
Per other CR, there may be a problem here with repeated keys.
Add a warning to log if that happens.

[hjon, 2016-01-06 00:39:14]

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats.h
File webrtc/api/objc/RTCStats.h (right):

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.h:19: //** Time since 1970-01-01T00:00:00Z in
milliseconds. */
On 2016/01/05 20:08:17, tkchin_webrtc wrote:
> /** not //**

Done.

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.h:26: @property(nonatomic, readonly) NSString *id;
On 2016/01/05 20:08:17, tkchin_webrtc wrote:
> statsId

Done.

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats.mm
File webrtc/api/objc/RTCStats.mm (right):

https://codereview.webrtc.org/1540113002/diff/20001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.mm:46: values[key] = value;
On 2016/01/05 20:08:17, tkchin_webrtc wrote:
> Per other CR, there may be a problem here with repeated keys.
> Add a warning to log if that happens.

Done.

https://codereview.webrtc.org/1540113002/diff/40001/webrtc/api/objc/RTCStats.mm
File webrtc/api/objc/RTCStats.mm (right):

https://codereview.webrtc.org/1540113002/diff/40001/webrtc/api/objc/RTCStats....
webrtc/api/objc/RTCStats.mm:49: RTCLogWarning(@"The |key| already exists in this
stats report: %@",
tkchin@ Is this the kind of logging you had in mind?

[tkchin_webrtc, 2016-01-06 20:12:46]

lgtm

[tkchin_webrtc, 2016-01-06 20:46:43]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-01-06 20:46:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1540113002/#ps80001 (title:
"Update against master")

[commit-bot: I haz the power, 2016-01-06 20:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540113002/80001

[commit-bot: I haz the power, 2016-01-06 22:47:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 22:47:20]

Try jobs failed on following builders:
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin_webrtc, 2016-01-11 17:57:18]

Needs to be merged before commit.

https://codereview.webrtc.org/1540113002/diff/80001/webrtc/api/objc/RTCStatsR...
File webrtc/api/objc/RTCStatsReport.mm (right):

https://codereview.webrtc.org/1540113002/diff/80001/webrtc/api/objc/RTCStatsR...
webrtc/api/objc/RTCStatsReport.mm:57: _values = [values copy];
copy not needed

[hjon, 2016-01-11 19:30:31]

https://codereview.webrtc.org/1540113002/diff/80001/webrtc/api/objc/RTCStatsR...
File webrtc/api/objc/RTCStatsReport.mm (right):

https://codereview.webrtc.org/1540113002/diff/80001/webrtc/api/objc/RTCStatsR...
webrtc/api/objc/RTCStatsReport.mm:57: _values = [values copy];
On 2016/01/11 17:57:18, tkchin_webrtc wrote:
> copy not needed

Done.

[tkchin_webrtc, 2016-01-11 21:11:49]

Description was changed from

==========
Update API for Objective-C RTCStats.

BUG=
==========

to

==========
Update API for Objective-C RTCStats.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a2c353f81571fa32ae008d745...
==========

[commit-bot: I haz the power, 2016-01-11 21:11:50]

Description was changed from

==========
Update API for Objective-C RTCStats.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a2c353f81571fa32ae008d745...
==========

to

==========
Update API for Objective-C RTCStats.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/a2c353f81571fa32ae008d74583e4ac32fa700df
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11207}
==========

[tkchin_webrtc, 2016-01-11 21:11:50]

Committed patchset #6 (id:100001) manually as
a2c353f81571fa32ae008d74583e4ac32fa700df (presubmit successful).

[commit-bot: I haz the power, 2016-01-11 21:11:51]

Patchset 6 (id:??) landed as
https://crrev.com/a2c353f81571fa32ae008d74583e4ac32fa700df
Cr-Commit-Position: refs/heads/master@{#11207}