Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1540103002: Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12a… (Closed)

Created:
5 years ago by ivoc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87. The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4. Original review: https://codereview.webrtc.org/1413483003/ The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function. TBR=glaznev@webrtc.org, henrik.lundin@webrtc.org, solenberg@google.com, henrikg@webrtc.org, perkj@webrtc.org BUG=webrtc:4741 Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a Cr-Commit-Position: refs/heads/master@{#11093} Committed: https://crrev.com/d66b44d5655c41c10d8cc19c1d24f952e441d13b Cr-Commit-Position: refs/heads/master@{#11267}

Patch Set 1 : Original CL. #

Patch Set 2 : Another attempt to fix compile errors on Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -60 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +4 lines, -3 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +5 lines, -3 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 chunk +3 lines, -1 line 0 comments Download
M talk/media/base/mediaengine.h View 2 chunks +6 lines, -4 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +5 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 chunk +4 lines, -2 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 13 chunks +28 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 1 chunk +12 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 9 chunks +34 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540103002/20001
5 years ago (2015-12-19 18:50:13 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/665)
5 years ago (2015-12-19 18:54:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540103002/40001
5 years ago (2015-12-21 11:03:53 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
5 years ago (2015-12-21 13:04:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540103002/40001
4 years, 11 months ago (2016-01-15 10:03:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-15 11:06:40 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 11:06:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d66b44d5655c41c10d8cc19c1d24f952e441d13b
Cr-Commit-Position: refs/heads/master@{#11267}

Powered by Google App Engine
This is Rietveld 408576698