Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1539513002: Deleted declaration of VideoCaptureInput::DeliverI420Frame (Closed)

Created:
5 years ago by nisse-webrtc
Modified:
5 years ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Deleted declaration of VideoCaptureInput::DeliverI420Frame It appears unimplemented and unused. BUG= Committed: https://crrev.com/5a4ce2fd338fd8b457b7ba0b2a2826e6fff0bb1e Cr-Commit-Position: refs/heads/master@{#11071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/video/video_capture_input.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539513002/1
5 years ago (2015-12-17 14:43:34 UTC) #4
nisse-webrtc
I have no idea what the function used to do, but it seems it no ...
5 years ago (2015-12-17 15:03:42 UTC) #5
pbos-webrtc
lgtm
5 years ago (2015-12-17 15:04:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539513002/1
5 years ago (2015-12-17 15:13:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 17:37:27 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-17 17:37:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4ce2fd338fd8b457b7ba0b2a2826e6fff0bb1e
Cr-Commit-Position: refs/heads/master@{#11071}

Powered by Google App Engine
This is Rietveld 408576698