Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1539423003: [rtp_rtcp] Lint errors cleaned from rtp_utility (Closed)

Created:
4 years, 12 months ago by danilchap
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] Lint errors cleaned from rtp_utility R=åsapersson BUG=webrtc:5277 Committed: https://crrev.com/f6975f46131981f83e0c88d276dee6b6c5753180 Cr-Commit-Position: refs/heads/master@{#11131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -170 lines) Patch
M webrtc/modules/rtp_rtcp/source/CPPLINT.cfg View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 9 chunks +10 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 20 chunks +21 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 2 chunks +37 lines, -58 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 13 chunks +38 lines, -70 lines 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/rtp_file_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/rtp_file_reader_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
danilchap
This cleaning is less aggressive than CL#1481773004: two unused functions (pow2 and OldTimestamp) still deleted, ...
4 years, 12 months ago (2015-12-22 10:19:22 UTC) #1
åsapersson
lgtm
4 years, 12 months ago (2015-12-22 10:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539423003/1
4 years, 12 months ago (2015-12-22 10:55:37 UTC) #4
commit-bot: I haz the power
Exceeded global retry quota
4 years, 12 months ago (2015-12-22 11:10:26 UTC) #6
pbos-webrtc
webrtc/test, webrtc/video lgtm
4 years, 11 months ago (2015-12-28 17:06:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539423003/1
4 years, 11 months ago (2015-12-28 17:06:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 18:18:52 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6975f46131981f83e0c88d276dee6b6c5753180 Cr-Commit-Position: refs/heads/master@{#11131}
4 years, 11 months ago (2015-12-28 18:18:57 UTC) #15
kjellander_webrtc
4 years, 11 months ago (2016-01-04 12:47:40 UTC) #16
Message was sent while issue was closed.
On 2015/12/28 18:18:57, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f6975f46131981f83e0c88d276dee6b6c5753180
> Cr-Commit-Position: refs/heads/master@{#11131}

FTR: this broke some users of the RtpHeaderParser::Parse function, and was later
fixed in https://codereview.webrtc.org/1550283002

Powered by Google App Engine
This is Rietveld 408576698