[rtp_rtcp] cleanup in RTCPSender class internals.

[rtp_rtcp] cleanup in RTCPSender class internals.
PrepareReportBlock and AddReportBlock private functions merged:
  PrepareReportBlock moved report block from statistic to temporary structure
  AddReportBlock copied that temporary structure into temporary map right after.
  Thanks to rtcp packet classes that temporary structure is now unneccesary.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/a72e7349d52366655076e609e9e32d456da7f5a2
Cr-Commit-Position: refs/heads/master@{#11112}

[åsapersson, 2015-12-22 08:57:56]

lgtm

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:918: rtcp::ReportBlock& block =
report_blocks_[ssrc];
use pointer?

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:921: if
(!block.WithCumulativeLost(stats.cumulative_lost)) {
Should cum lost wrap or be set to the max? We should probably fix this in the
statistics class (instead of not sending the report).
Perhaps add a comment/todo.

[danilchap, 2015-12-22 09:53:37]

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:918: rtcp::ReportBlock& block =
report_blocks_[ssrc];
On 2015/12/22 08:57:56, åsapersson wrote:
> use pointer?

Done.

https://codereview.webrtc.org/1538833002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:921: if
(!block.WithCumulativeLost(stats.cumulative_lost)) {
On 2015/12/22 08:57:56, åsapersson wrote:
> Should cum lost wrap or be set to the max? We should probably fix this in the
> statistics class (instead of not sending the report).
> Perhaps add a comment/todo.

Added TODO comment to receive_statistic_impl

[danilchap, 2015-12-22 13:40:46]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-22 13:40:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1538833002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-12-22 13:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538833002/20001

[commit-bot: I haz the power, 2015-12-22 14:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 14:49:26]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8134)

[danilchap, 2015-12-22 15:38:42]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2015-12-22 15:38:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538833002/20001

[commit-bot: I haz the power, 2015-12-22 16:07:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-22 16:07:55]

Description was changed from

==========
[rtp_rtcp] cleanup in RTCPSender class internals.
PrepareReportBlock and AddReportBlock private functions merged:
  PrepareReportBlock moved report block from statistic to temporary structure
  AddReportBlock copied that temporary structure into temporary map right after.
  Thanks to rtcp packet classes that temporary structure is now unneccesary.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] cleanup in RTCPSender class internals.
PrepareReportBlock and AddReportBlock private functions merged:
  PrepareReportBlock moved report block from statistic to temporary structure
  AddReportBlock copied that temporary structure into temporary map right after.
  Thanks to rtcp packet classes that temporary structure is now unneccesary.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/a72e7349d52366655076e609e9e32d456da7f5a2
Cr-Commit-Position: refs/heads/master@{#11112}
==========

[commit-bot: I haz the power, 2015-12-22 16:07:55]

Patchset 2 (id:??) landed as
https://crrev.com/a72e7349d52366655076e609e9e32d456da7f5a2
Cr-Commit-Position: refs/heads/master@{#11112}