Update API for Objective-C RTCMediaSource.

Update API for Objective-C RTCMediaSource.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/f6c318ebae89bc1a6fac1207a0f32380e6508d33
Patch from Jon Hjelle <hjon@andyet.net>;.

Cr-Commit-Position: refs/heads/master@{#11210}

[hjon, 2015-12-20 23:26:10]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[hjon, 2015-12-20 23:26:11]

Like https://codereview.webrtc.org/1527143002/, I'm not sure I like the naming
for the enum conversion methods.

[tkchin_webrtc, 2016-01-05 18:44:35]

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
File webrtc/api/objc/RTCMediaSource+Private.h (right):

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource+Private.h:27: -
(instancetype)initWithMediaSource:
initWithNativeMediaSource

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
File webrtc/api/objc/RTCMediaSource.mm (right):

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource.mm:15: @interface RTCMediaSource () {
? Don't think you need this to be public

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource.mm:48: +
(webrtc::MediaSourceInterface::SourceState)nativeSourceStateForObjCSourceState:
just remove "ObjCSource" from all of these and it should be fine

[hjon, 2016-01-06 00:17:15]

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
File webrtc/api/objc/RTCMediaSource+Private.h (right):

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource+Private.h:27: -
(instancetype)initWithMediaSource:
On 2016/01/05 18:44:34, tkchin_webrtc wrote:
> initWithNativeMediaSource

Done.

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
File webrtc/api/objc/RTCMediaSource.mm (right):

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource.mm:15: @interface RTCMediaSource () {
On 2016/01/05 18:44:34, tkchin_webrtc wrote:
> ? Don't think you need this to be public

Quite right. :-)

https://codereview.webrtc.org/1538263002/diff/1/webrtc/api/objc/RTCMediaSourc...
webrtc/api/objc/RTCMediaSource.mm:48: +
(webrtc::MediaSourceInterface::SourceState)nativeSourceStateForObjCSourceState:
On 2016/01/05 18:44:34, tkchin_webrtc wrote:
> just remove "ObjCSource" from all of these and it should be fine

Done.

[tkchin_webrtc, 2016-01-11 21:25:37]

lgtm

[tkchin_webrtc, 2016-01-11 22:39:09]

Description was changed from

==========
Update API for Objective-C RTCMediaSource.

BUG=
==========

to

==========
Update API for Objective-C RTCMediaSource.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f6c318ebae89bc1a6fac1207a...
==========

[tkchin_webrtc, 2016-01-11 22:39:10]

Committed patchset #7 (id:120001) manually as
f6c318ebae89bc1a6fac1207a0f32380e6508d33 (presubmit successful).

[commit-bot: I haz the power, 2016-01-11 22:39:11]

Description was changed from

==========
Update API for Objective-C RTCMediaSource.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f6c318ebae89bc1a6fac1207a...
==========

to

==========
Update API for Objective-C RTCMediaSource.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/f6c318ebae89bc1a6fac1207a0f32380e6508d33
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11210}
==========

[commit-bot: I haz the power, 2016-01-11 22:39:11]

Patchset 7 (id:??) landed as
https://crrev.com/f6c318ebae89bc1a6fac1207a0f32380e6508d33
Cr-Commit-Position: refs/heads/master@{#11210}