Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 1537943002: delete basictypes.h header (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/basicdefs.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
PTAL! I almost forgot about this.
5 years ago (2015-12-18 13:49:05 UTC) #1
tommi
lgtm
5 years ago (2015-12-18 14:10:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537943002/1
5 years ago (2015-12-18 14:11:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 15:33:06 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-18 15:33:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1cd566cc6254802c9554ee006b0b809ff77aa55
Cr-Commit-Position: refs/heads/master@{#11085}

Powered by Google App Engine
This is Rietveld 408576698