Fix pointer compare-and-swap on Windows.

webrtc/base/atomicops.h

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 26 matching lines @@
   static void ReleaseStore(volatile int* i, int value) {
     *i = value;
   }
   static int CompareAndSwap(volatile int* i, int old_value, int new_value) {
     return ::InterlockedCompareExchange(reinterpret_cast<volatile LONG*>(i),
                                         new_value,
                                         old_value);
   }
   // Pointer variants.
   template <typename T>
-  static T* AtomicLoadPtr(T* volatile* ptr) {
+  static T* AcquireLoadPtr(T* volatile* ptr) {
     return *ptr;
   }
   template <typename T>
   static T* CompareAndSwapPtr(T* volatile* ptr, T* old_value, T* new_value) {
     return static_cast<T*>(::InterlockedCompareExchangePointer(
-        reinterpret_cast<PVOID volatile*>(ptr), old_value, new_value));
+        reinterpret_cast<PVOID volatile*>(ptr), new_value, old_value));
   }
 #else
   static int Increment(volatile int* i) {
     return __sync_add_and_fetch(i, 1);
   }
   static int Decrement(volatile int* i) {
     return __sync_sub_and_fetch(i, 1);
   }
   static int AcquireLoad(volatile const int* i) {
     return __atomic_load_n(i, __ATOMIC_ACQUIRE);
   }
   static void ReleaseStore(volatile int* i, int value) {
     __atomic_store_n(i, value, __ATOMIC_RELEASE);
   }
   static int CompareAndSwap(volatile int* i, int old_value, int new_value) {
     return __sync_val_compare_and_swap(i, old_value, new_value);
   }
   // Pointer variants.
   template <typename T>
-  static T* AtomicLoadPtr(T* volatile* ptr) {
+  static T* AcquireLoadPtr(T* volatile* ptr) {
     return __atomic_load_n(ptr, __ATOMIC_ACQUIRE);
   }
   template <typename T>
   static T* CompareAndSwapPtr(T* volatile* ptr, T* old_value, T* new_value) {
     return __sync_val_compare_and_swap(ptr, old_value, new_value);
   }
 #endif
 };
 
 
 
 }
 
 #endif  // WEBRTC_BASE_ATOMICOPS_H_