Step 1 to prepare call_test.* for combined audio/video tests.

Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
Committed: https://crrev.com/ff483617a4fdf282bb82d7f4ce15af3dbe305a4a
Cr-Commit-Position: refs/heads/master@{#11101}

[stefan-webrtc, 2015-12-21 09:21:18]

Cleanups

[stefan-webrtc, 2015-12-21 09:21:39]

Description was changed from

==========
Prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

BUG=webrtc:5263
==========

to

==========
Prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

[stefan-webrtc, 2015-12-21 09:23:10]

Description was changed from

==========
Prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

to

==========
Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

[stefan-webrtc, 2015-12-21 09:29:33]

stefan@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[stefan-webrtc, 2015-12-21 09:29:56]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-21 09:29:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537273003/20001

[stefan-webrtc, 2015-12-21 09:39:43]

stefan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[stefan-webrtc, 2015-12-21 09:39:43]

+mflodman as he expressed interest in reviewing this.

[commit-bot: I haz the power, 2015-12-21 10:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 10:24:44]

Dry run: This issue passed the CQ dry run.

[phoglund, 2015-12-21 10:36:14]

No objections to the changes themselves. This is the first time I look at this
code though, and I think you need to very careful. These tests are already
really complex, almost to the point when they start to need unit tests
themselves. If you plan to make the test framework support more kinds of tests,
I think you need to think about refactoring or at least be very careful how you
add the new functionality. Let's talk more offline about that.

lgtm

[stefan-webrtc, 2015-12-21 10:46:15]

On 2015/12/21 10:36:14, phoglund wrote:
> No objections to the changes themselves. This is the first time I look at this
> code though, and I think you need to very careful. These tests are already
> really complex, almost to the point when they start to need unit tests
> themselves. If you plan to make the test framework support more kinds of
tests,
> I think you need to think about refactoring or at least be very careful how
you
> add the new functionality. Let's talk more offline about that.

Agree, that they are complex already, but I think this is the right thing to do
anyway, since it will substantially simplify writing end-to-end audio tests,
which AFAIK, there are none of today at this level. We may even be able to reuse
some of the tests we already have written for video. Even better is that we will
be able to easily write combined audio/video bandwidth estimation tests when I'm
done with this, and hopefully reduce the complexity of the audio/video sync test
in call_perf_tests.cc.

Both Magnus and I will be working on this test improvement, and I'm sure
solenberg and kwiberg will invest a lot of time on this when they get further on
the new audio APIs. I hope the work I'm doing right now won't add too much
complexity though.

Thanks for reviewing!

[stefan-webrtc, 2015-12-21 10:46:32]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-12-21 10:46:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537273003/20001

[commit-bot: I haz the power, 2015-12-21 11:14:03]

Description was changed from

==========
Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

to

==========
Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

[commit-bot: I haz the power, 2015-12-21 11:14:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 11:14:09]

Description was changed from

==========
Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263
==========

to

==========
Step 1 to prepare call_test.* for combined audio/video tests.

Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation
for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263

Committed: https://crrev.com/ff483617a4fdf282bb82d7f4ce15af3dbe305a4a
Cr-Commit-Position: refs/heads/master@{#11101}
==========

[commit-bot: I haz the power, 2015-12-21 11:14:09]

Patchset 2 (id:??) landed as
https://crrev.com/ff483617a4fdf282bb82d7f4ce15af3dbe305a4a
Cr-Commit-Position: refs/heads/master@{#11101}