Remove duplicate code in SocketDispatcher

Remove duplicate code in SocketDispatcher

This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.

Here the duplicate implementations are merged with only some #ifdef parts.

BUG=

Committed: https://crrev.com/4331fcd51736b030f30c31a35c732f119b31b6fc
Cr-Commit-Position: refs/heads/master@{#11160}

[joachim, 2015-12-20 15:27:32]

jbauch@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[joachim, 2015-12-20 15:27:32]

Ptal

https://codereview.webrtc.org/1537273002/diff/1/webrtc/base/physicalsocketser...
File webrtc/base/physicalsocketserver.cc (right):

https://codereview.webrtc.org/1537273002/diff/1/webrtc/base/physicalsocketser...
webrtc/base/physicalsocketserver.cc:608: SOCKET SocketDispatcher::GetSocket() {
This could probably be further merged with GetDescriptor from the WEBRTC_POSIX
class.

[guoweis_webrtc, 2015-12-29 20:01:44]

On 2015/12/20 15:27:32, joachim wrote:
> Ptal
> 
>
https://codereview.webrtc.org/1537273002/diff/1/webrtc/base/physicalsocketser...
> File webrtc/base/physicalsocketserver.cc (right):
> 
>
https://codereview.webrtc.org/1537273002/diff/1/webrtc/base/physicalsocketser...
> webrtc/base/physicalsocketserver.cc:608: SOCKET SocketDispatcher::GetSocket()
{
> This could probably be further merged with GetDescriptor from the WEBRTC_POSIX
> class.

This looks like an exact merge of two copies of code.
lgtm

[pthatcher, 2016-01-06 23:00:41]

The CQ bit was checked by pthatcher@google.com

[pthatcher, 2016-01-06 23:00:44]

The CQ bit was unchecked by pthatcher@google.com

[pthatcher1, 2016-01-06 23:00:57]

The CQ bit was checked by pthatcher@webrtc.org

[commit-bot: I haz the power, 2016-01-06 23:01:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537273002/1

[pthatcher1, 2016-01-06 23:02:15]

lgtm

[commit-bot: I haz the power, 2016-01-07 01:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 01:02:25]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[joachim, 2016-01-07 06:16:33]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2016-01-07 06:16:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537273002/1

[commit-bot: I haz the power, 2016-01-07 06:20:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-07 06:20:38]

Description was changed from

==========
Remove duplicate code in SocketDispatcher

This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.

Here the duplicate implementations are merged with only some #ifdef parts.

BUG=
==========

to

==========
Remove duplicate code in SocketDispatcher

This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.

Here the duplicate implementations are merged with only some #ifdef parts.

BUG=

Committed: https://crrev.com/4331fcd51736b030f30c31a35c732f119b31b6fc
Cr-Commit-Position: refs/heads/master@{#11160}
==========

[commit-bot: I haz the power, 2016-01-07 06:20:39]

Patchset 1 (id:??) landed as
https://crrev.com/4331fcd51736b030f30c31a35c732f119b31b6fc
Cr-Commit-Position: refs/heads/master@{#11160}