Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: talk/media/base/mediaengine.h

Issue 1537213002: Revert of Reland "Added option to specify a maximum file size when recording an AEC dump." (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/fakewebrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index cd533c443ef0ae2c851e8140fc77cc230ac2fb0f..43b4de5a52ddf8467def3ea4c77662057f0655e7 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -102,10 +102,8 @@
virtual const std::vector<VideoCodec>& video_codecs() = 0;
virtual RtpCapabilities GetVideoCapabilities() = 0;
- // Starts AEC dump using existing file, a maximum file size in bytes can be
- // specified. Logging is stopped just before the size limit is exceeded.
- // If max_size_bytes is set to a value <= 0, no limit will be used.
- virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
+ // Starts AEC dump using existing file.
+ virtual bool StartAecDump(rtc::PlatformFile file) = 0;
// Stops recording AEC dump.
virtual void StopAecDump() = 0;
@@ -187,8 +185,8 @@
return video_.GetCapabilities();
}
- virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
- return voice_.StartAecDump(file, max_size_bytes);
+ virtual bool StartAecDump(rtc::PlatformFile file) {
+ return voice_.StartAecDump(file);
}
virtual void StopAecDump() {
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | talk/media/webrtc/fakewebrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698