Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1536563005: Increasing timeout for TestResolverShutdown. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increasing timeout for TestResolverShutdown. getaddrinfo() seems to take longer than a second occasionally. BUG=webrtc:5191 R=pthatcher@webrtc.org Committed: https://crrev.com/e86e15b2a2ee208e2d8edbb1c2d73274d9b8aec7 Cr-Commit-Position: refs/heads/master@{#11138}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding comment. #

Patch Set 3 : Fixing unused variable compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/p2p/base/turnport_unittest.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
Taylor Brandstetter
5 years ago (2015-12-18 21:30:45 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/1536563005/diff/1/webrtc/p2p/base/turnport_unittest.cc File webrtc/p2p/base/turnport_unittest.cc (right): https://codereview.webrtc.org/1536563005/diff/1/webrtc/p2p/base/turnport_unittest.cc#newcode71 webrtc/p2p/base/turnport_unittest.cc:71: static const unsigned int kResolverTimeout = 10000; Can ...
5 years ago (2015-12-18 21:51:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536563005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536563005/20001
4 years, 12 months ago (2015-12-28 20:43:26 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
4 years, 12 months ago (2015-12-28 20:53:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536563005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536563005/40001
4 years, 11 months ago (2015-12-29 18:45:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8217)
4 years, 11 months ago (2015-12-29 20:50:16 UTC) #13
Taylor Brandstetter
Committed patchset #3 (id:40001) manually as e86e15b2a2ee208e2d8edbb1c2d73274d9b8aec7 (presubmit successful).
4 years, 11 months ago (2015-12-29 20:51:26 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 20:51:27 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e86e15b2a2ee208e2d8edbb1c2d73274d9b8aec7
Cr-Commit-Position: refs/heads/master@{#11138}

Powered by Google App Engine
This is Rietveld 408576698