Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1535993002: remove deprecated StringToIP() methods from SocketAddress API (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

remove deprecated StringToIP() methods from SocketAddress API This patch removes StringToIP() methods as fixes the TODO there and there are no callers at the moment for these methods. BUG=None R=perkj@webrtc.org Committed: https://crrev.com/c155b16b220da971a5f7cf6d792a656e4a878cb5 Cr-Commit-Position: refs/heads/master@{#11088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M webrtc/base/socketaddress.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/base/socketaddress.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
PTAL!
5 years ago (2015-12-18 13:49:14 UTC) #1
tommi
lgtm
5 years ago (2015-12-18 14:11:38 UTC) #3
perkj_webrtc
lgtm
5 years ago (2015-12-18 14:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535993002/1
5 years ago (2015-12-18 14:11:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 16:13:13 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-18 16:13:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c155b16b220da971a5f7cf6d792a656e4a878cb5
Cr-Commit-Position: refs/heads/master@{#11088}

Powered by Google App Engine
This is Rietveld 408576698