webrtc/call/congestion_controller.cc - Issue 1535963002: Wire-up BWE feedback for audio receive streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/congestion_controller.cc

Issue 1535963002: Wire-up BWE feedback for audio receive streams. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/call/congestion_controller.cc

diff --git a/webrtc/call/congestion_controller.cc b/webrtc/call/congestion_controller.cc

index c442667ae0e43b5a7482a85c5a5275d69f67d473..c5154634ca973cff888af66bf4f0ca7178568538 100644

--- a/webrtc/call/congestion_controller.cc

+++ b/webrtc/call/congestion_controller.cc

@@ -169,6 +169,7 @@ CongestionController::CongestionController(ProcessThread* process_thread,

BitrateController::CreateBitrateController(Clock::GetRealTimeClock(),

bitrate_observer)),

min_bitrate_bps_(RemoteBitrateEstimator::kDefaultMinBitrateBps) {

+ RTC_DCHECK(bitrate_observer);

mflodman 2016/01/12 12:42:53 I don't this check makes sense here, since it's no

stefan-webrtc 2016/01/12 12:53:18 I'll remove it for now.

call_stats_->RegisterStatsObserver(remote_bitrate_estimator_.get());

pacer_thread_->RegisterModule(pacer_.get());