Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: webrtc/audio_receive_stream.h

Issue 1535963002: Wire-up BWE feedback for audio receive streams. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comment addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_send_stream_unittest.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // Receive-stream specific RTP settings. 66 // Receive-stream specific RTP settings.
67 struct Rtp { 67 struct Rtp {
68 std::string ToString() const; 68 std::string ToString() const;
69 69
70 // Synchronization source (stream identifier) to be received. 70 // Synchronization source (stream identifier) to be received.
71 uint32_t remote_ssrc = 0; 71 uint32_t remote_ssrc = 0;
72 72
73 // Sender SSRC used for sending RTCP (such as receiver reports). 73 // Sender SSRC used for sending RTCP (such as receiver reports).
74 uint32_t local_ssrc = 0; 74 uint32_t local_ssrc = 0;
75 75
76 // Enable feedback for send side bandwidth estimation.
77 // See
78 // https://tools.ietf.org/html/draft-holmer-rmcat-transport-wide-cc-extens ions
79 // for details.
80 bool transport_cc = false;
81
76 // RTP header extensions used for the received stream. 82 // RTP header extensions used for the received stream.
77 std::vector<RtpExtension> extensions; 83 std::vector<RtpExtension> extensions;
78 } rtp; 84 } rtp;
79 85
80 Transport* receive_transport = nullptr; 86 Transport* receive_transport = nullptr;
81 Transport* rtcp_send_transport = nullptr; 87 Transport* rtcp_send_transport = nullptr;
82 88
83 // Underlying VoiceEngine handle, used to map AudioReceiveStream to lower- 89 // Underlying VoiceEngine handle, used to map AudioReceiveStream to lower-
84 // level components. 90 // level components.
85 // TODO(solenberg): Remove when VoiceEngine channels are created outside 91 // TODO(solenberg): Remove when VoiceEngine channels are created outside
(...skipping 23 matching lines...) Expand all
109 // Only one sink can be set and passing a null sink, clears an existing one. 115 // Only one sink can be set and passing a null sink, clears an existing one.
110 // NOTE: Audio must still somehow be pulled through AudioTransport for audio 116 // NOTE: Audio must still somehow be pulled through AudioTransport for audio
111 // to stream through this sink. In practice, this happens if mixed audio 117 // to stream through this sink. In practice, this happens if mixed audio
112 // is being pulled+rendered and/or if audio is being pulled for the purposes 118 // is being pulled+rendered and/or if audio is being pulled for the purposes
113 // of feeding to the AEC. 119 // of feeding to the AEC.
114 virtual void SetSink(rtc::scoped_ptr<AudioSinkInterface> sink) = 0; 120 virtual void SetSink(rtc::scoped_ptr<AudioSinkInterface> sink) = 0;
115 }; 121 };
116 } // namespace webrtc 122 } // namespace webrtc
117 123
118 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_ 124 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/audio/audio_send_stream_unittest.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698