Wire-up BWE feedback for audio receive streams.

webrtc/call/congestion_controller.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 129 matching lines @@
   int min_bitrate_bps_;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WrappingBitrateEstimator);
 };
 
 }  // namespace
 
 CongestionController::CongestionController(ProcessThread* process_thread,
                                            CallStats* call_stats,
                                            BitrateObserver* bitrate_observer)
     : remb_(new VieRemb(Clock::GetRealTimeClock())),

[the sun, 2016/01/11 11:47:19]

separate CL?
We now have the MockCC depending on real time clock.

[stefan-webrtc, 2016/01/11 17:15:48]

Maybe, on the other hand it will never be affected by it since it's not possible
to access remb_ in any way. If you are using the MockCC you will not be able to
call any methods of the base CongestionController?

Not sure it makes sense to expose the clock in CongestionController if we are
not using it in a test?

[the sun, 2016/01/12 10:24:13]

However confusingly phrased, my concern was really more about testability of the
CC class itself... :)

[stefan-webrtc, 2016/01/12 11:15:15]

I see, then let's leave that to when we actually make changes to the CC class

       packet_router_(new PacketRouter()),
       pacer_(new PacedSender(Clock::GetRealTimeClock(),
                              packet_router_.get(),
                              BitrateController::kDefaultStartBitrateKbps,
                              PacedSender::kDefaultPaceMultiplier *
                                  BitrateController::kDefaultStartBitrateKbps,
                              0)),
       remote_bitrate_estimator_(
           new WrappingBitrateEstimator(remb_.get(), Clock::GetRealTimeClock())),
       remote_estimator_proxy_(
           new RemoteEstimatorProxy(Clock::GetRealTimeClock(),
                                    packet_router_.get())),
       process_thread_(process_thread),
       call_stats_(call_stats),
       pacer_thread_(ProcessThread::Create("PacerThread")),
       // Constructed last as this object calls the provided callback on
       // construction.
       bitrate_controller_(
           BitrateController::CreateBitrateController(Clock::GetRealTimeClock(),
                                                      bitrate_observer)),
       min_bitrate_bps_(RemoteBitrateEstimator::kDefaultMinBitrateBps) {
+  RTC_DCHECK(bitrate_observer != nullptr);

[the sun, 2016/01/11 11:47:19]

nit: != nullptr not necessary

[stefan-webrtc, 2016/01/11 17:15:48]

Done.

   call_stats_->RegisterStatsObserver(remote_bitrate_estimator_.get());
 
   pacer_thread_->RegisterModule(pacer_.get());
   pacer_thread_->Start();
 
   process_thread->RegisterModule(remote_estimator_proxy_.get());
   process_thread->RegisterModule(remote_bitrate_estimator_.get());
   process_thread->RegisterModule(bitrate_controller_.get());
 }
 
@@ skipping 103 matching lines @@
   }
 }
 
 void CongestionController::OnSentPacket(const rtc::SentPacket& sent_packet) {
   if (transport_feedback_adapter_) {
     transport_feedback_adapter_->OnSentPacket(sent_packet.packet_id,
                                               sent_packet.send_time_ms);
   }
 }
 }  // namespace webrtc