Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1534363002: Fixing issue where description contains empty ICE ufrag/pwd. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
4 years, 12 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing issue where description contains empty ICE ufrag/pwd. The issue occurred when deserializing and then serializing a rejected content description, which doesn't have the ICE ufrag/pwd in the first place. BUG=webrtc:5105 Committed: https://crrev.com/3f7219be700df3fea85193e8d541e7f90a1c3ce6 Cr-Commit-Position: refs/heads/master@{#11134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -21 lines) Patch
M talk/app/webrtc/webrtcsdp.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 7 chunks +46 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Taylor Brandstetter
5 years ago (2015-12-18 23:51:56 UTC) #2
pthatcher1
lgtm
5 years ago (2015-12-22 23:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534363002/1
4 years, 12 months ago (2015-12-28 20:42:17 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 12 months ago (2015-12-28 20:56:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534363002/1
4 years, 12 months ago (2015-12-28 23:15:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 23:17:17 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 23:17:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f7219be700df3fea85193e8d541e7f90a1c3ce6
Cr-Commit-Position: refs/heads/master@{#11134}

Powered by Google App Engine
This is Rietveld 408576698