Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1533193003:
Move RTCI420Frame with minor style changes. (Closed)
|
Created:
5 years ago by hjon Modified:
4 years, 11 months ago Reviewers:
tkchin_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMove RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes.
BUG=
R=tkchin@webrtc.org
Committed: https://crrev.com/78234956985d837ebdc16b0fc5d6cea8de9192a2
Patch from Jon Hjelle <hjon@andyet.net>;.
Cr-Commit-Position: refs/heads/master@{#11203}
Patch Set 1 #Patch Set 2 : Update parameter type #
Total comments: 8
Patch Set 3 : Changes from feedback #Patch Set 4 : Update naming #Patch Set 5 : Update against master #
Messages
Total messages: 35 (17 generated)
Description was changed from ========== Move RTCI420Frame with minor style changes. BUG= ========== to ========== Move RTCI420Frame to webrtc/api/objc with minor style changes. BUG= ==========
hjon@andyet.net changed reviewers: + tkchin@webrtc.org
Moved to webrtc/api/objc nearly verbatim. I made a couple of small style changes to try match the style of the other code in webrtc/api/objc.
On 2015/12/20 23:19:56, hjon wrote: > Moved to webrtc/api/objc nearly verbatim. I made a couple of small style changes > to try match the style of the other code in webrtc/api/objc. lgtm
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533193003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/11648)
https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... File webrtc/api/objc/RTCI420Frame.h (right): https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:15: @interface RTCI420Frame : NSObject can we change this to RTCVideoFrame instead? https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:35: - (BOOL)makeExclusive; don't think we need makeExclusive anymore https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... File webrtc/api/objc/RTCI420Frame.mm (right): https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.mm:74: - (instancetype)initWithVideoFrame:(const cricket::VideoFrame *)videoFrame { to keep in line with the new stuff: initWIthNativeFrame
https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... File webrtc/api/objc/RTCI420Frame.h (right): https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:18: @property(nonatomic, readonly) NSUInteger width; I don't remember why we casted this to NSInteger/NSUInteger. Probably better to keep the C++ size_t/int32_t
Description was changed from ========== Move RTCI420Frame to webrtc/api/objc with minor style changes. BUG= ========== to ========== Move RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes. BUG= ==========
https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... File webrtc/api/objc/RTCI420Frame.h (right): https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:15: @interface RTCI420Frame : NSObject On 2016/01/05 17:09:28, tkchin_webrtc wrote: > can we change this to RTCVideoFrame instead? Done. https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:18: @property(nonatomic, readonly) NSUInteger width; On 2016/01/05 17:20:17, tkchin_webrtc wrote: > I don't remember why we casted this to NSInteger/NSUInteger. > > Probably better to keep the C++ size_t/int32_t Done. https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.h:35: - (BOOL)makeExclusive; On 2016/01/05 17:09:28, tkchin_webrtc wrote: > don't think we need makeExclusive anymore Done. https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... File webrtc/api/objc/RTCI420Frame.mm (right): https://codereview.webrtc.org/1533193003/diff/20001/webrtc/api/objc/RTCI420Fr... webrtc/api/objc/RTCI420Frame.mm:74: - (instancetype)initWithVideoFrame:(const cricket::VideoFrame *)videoFrame { On 2016/01/05 17:09:28, tkchin_webrtc wrote: > to keep in line with the new stuff: initWIthNativeFrame Done.
The CQ bit was checked by tkchin@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1533193003/#ps60001 (title: "Update naming")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533193003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533193003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533193003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533193003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2708)
The CQ bit was checked by tkchin@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1533193003/#ps80001 (title: "Update against master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533193003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533193003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533193003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533193003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Move RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes. BUG= ========== to ========== Move RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes. BUG= R=tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/78234956985d837ebdc16b0fc... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 78234956985d837ebdc16b0fc5d6cea8de9192a2 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Move RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes. BUG= R=tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/78234956985d837ebdc16b0fc... ========== to ========== Move RTCI420Frame to webrtc/api/objc/RTCVideoFrame with minor style changes. BUG= R=tkchin@webrtc.org Committed: https://crrev.com/78234956985d837ebdc16b0fc5d6cea8de9192a2 Patch from Jon Hjelle <hjon@andyet.net>. Cr-Commit-Position: refs/heads/master@{#11203} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/78234956985d837ebdc16b0fc5d6cea8de9192a2 Cr-Commit-Position: refs/heads/master@{#11203} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
