Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1532333002: Defines for ARM and MIPS CPU types. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Defines for ARM and MIPS CPU types. This removes a dependency on Chromium's build/build_config.h (which is not allowed). The added defines are identical to the ones in build/build_config.h. NOTRY=True Committed: https://crrev.com/9b7fc7f25d20a4e4562ec79e8a2aa9798956f80c Cr-Commit-Position: refs/heads/master@{#11082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/modules/desktop_capture/differ_block.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/typedefs.h View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
(ignore the iOS GN bots, they're failing because GN is not yet building on iOS, ...
5 years ago (2015-12-18 11:54:34 UTC) #3
tommi
lgtm
5 years ago (2015-12-18 11:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532333002/1
5 years ago (2015-12-18 12:27:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 12:28:44 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-18 12:28:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b7fc7f25d20a4e4562ec79e8a2aa9798956f80c
Cr-Commit-Position: refs/heads/master@{#11082}

Powered by Google App Engine
This is Rietveld 408576698