Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1532133002: Deleted VideoCapturer::screencast_max_pixels and related unused code. (Closed)

Created:
5 years ago by nisse-webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Deleted VideoCapturer::screencast_max_pixels, together with VideoChannel::GetScreencastMaxPixels and VideoChannel::GetScreencastFps. Unused in webrtc, also unused in everything indexed by google and chromium code search. With the exception of the magicflute plugin, which I'm told doesn't matter. Committed: https://crrev.com/e6bf587259da23e96a8de0957b172fd74c36c3c6 Cr-Commit-Position: refs/heads/master@{#11108}

Patch Set 1 #

Patch Set 2 : Also delete the instance variable, and code handling screencast_max_pixels_ > 0 #

Patch Set 3 : Also delete VideoChannel::ScreencastDetailsData, VideoChannel::GetScreencastFps and VideoChannel::G… #

Patch Set 4 : Deleted test VideoCapturerTest.ScreencastScaledMaxPixels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -95 lines) Patch
M talk/media/base/videocapturer.h View 2 chunks +0 lines, -12 lines 0 comments Download
M talk/media/base/videocapturer.cc View 1 2 chunks +5 lines, -11 lines 0 comments Download
M talk/media/base/videocapturer_unittest.cc View 1 2 3 1 chunk +0 lines, -33 lines 0 comments Download
M talk/session/media/channel.h View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M talk/session/media/channel.cc View 1 2 3 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532133002/20001
5 years ago (2015-12-18 13:08:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532133002/40001
5 years ago (2015-12-18 13:20:47 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/11680)
5 years ago (2015-12-18 13:26:25 UTC) #8
nisse-webrtc
Please have a look, I'd like to remove this apparently unused feature. (I'm going to ...
5 years ago (2015-12-18 14:25:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532133002/60001
5 years ago (2015-12-18 14:31:24 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-12-18 16:32:19 UTC) #13
pthatcher1
lgtm
5 years ago (2015-12-18 21:16:24 UTC) #14
magjed_webrtc
lgtm
5 years ago (2015-12-21 11:22:00 UTC) #15
nisse-webrtc
Thanks. I don't want to land it just before going on vacation. If any of ...
5 years ago (2015-12-21 12:09:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532133002/60001
5 years ago (2015-12-21 20:21:29 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-21 21:18:17 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-21 21:18:20 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e6bf587259da23e96a8de0957b172fd74c36c3c6
Cr-Commit-Position: refs/heads/master@{#11108}

Powered by Google App Engine
This is Rietveld 408576698