Enable IPv6 temporary address filtering on iOS

webrtc/base/ifaddrs_converter.cc

+/*
+ *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/base/ifaddrs_converter.h"
+
+#include "webrtc/base/logging.h"
+
+namespace rtc {
+
+IfAddrsConverter::IfAddrsConverter() {}
+
+IfAddrsConverter::~IfAddrsConverter() {}
+
+bool IfAddrsConverter::Convert(const struct ifaddrs* interface,
+                               InterfaceAddress* ip,
+                               IPAddress* mask) {
+  switch (interface->ifa_addr->sa_family) {
+    case AF_INET: {
+      *ip = IPAddress(
+          reinterpret_cast<sockaddr_in*>(interface->ifa_addr)->sin_addr);
+      *mask = IPAddress(
+          reinterpret_cast<sockaddr_in*>(interface->ifa_netmask)->sin_addr);
+      return true;
+    }
+    case AF_INET6: {
+      int ip_attributes = IPV6_ADDRESS_FLAG_NONE;
+      if (!ConvertNativeToIPAttributes(interface, &ip_attributes)) {
+        return false;
+      }
+      *ip = InterfaceAddress(
+          reinterpret_cast<sockaddr_in6*>(interface->ifa_addr)->sin6_addr,
+          ip_attributes);
+      *mask = IPAddress(
+          reinterpret_cast<sockaddr_in6*>(interface->ifa_netmask)->sin6_addr);
+      LOG(LS_ERROR) << "IPv6 " << ip->ToString();

[pthatcher1, 2015/12/18 19:51:20]

Was this just a debugging statement that you should remove?

[guoweis_webrtc, 2015/12/21 20:26:33]

Sorry, missed this one.

+      return true;
+    }
+    default: { return false; }
+  }
+}
+
+bool IfAddrsConverter::ConvertNativeToIPAttributes(

[pthatcher1, 2015/12/18 19:51:20]

What is "native" in this context?  Should this be ConvertInterfaceToAttributes? 

[guoweis_webrtc, 2015/12/21 20:26:33]

I meant by native attributes. They have their own native definitions for mac and
linux, and I'm converting them to what we have in IPAddress.h.

[pthatcher1, 2015/12/21 22:18:32]

Then should it be named ConvertNativeAttributesToIPAttributes?

+    const struct ifaddrs* interface,
+    int* ip_attributes) {
+  *ip_attributes = IPV6_ADDRESS_FLAG_NONE;
+  return true;
+}
+
+#if !defined(WEBRTC_MAC)

[pthatcher1, 2015/12/18 19:51:20]

Can you leave a comment about what happens for mac?

[guoweis_webrtc, 2015/12/21 20:26:33]

Done.

+IfAddrsConverter* CreateIfAddrsConverter() {
+  return new IfAddrsConverter();
+}
+#endif
+}  // namespace rtc