Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530003004: Cleanup use of "do { ... } while (0)". (Closed)

Created:
5 years ago by torbjorng (webrtc)
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, sdk-team_agora.io, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup use of "do { ... } while (0)". BUG= Committed: https://crrev.com/a08925791ce431421f0c45b8380737cccc198349 Cr-Commit-Position: refs/heads/master@{#11061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M webrtc/base/gunit.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h View 5 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
torbjorng (webrtc)
5 years ago (2015-12-16 19:24:59 UTC) #3
tommi
lgtm
5 years ago (2015-12-16 23:50:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530003004/1
5 years ago (2015-12-16 23:50:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 02:38:35 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 02:38:39 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a08925791ce431421f0c45b8380737cccc198349
Cr-Commit-Position: refs/heads/master@{#11061}

Powered by Google App Engine
This is Rietveld 408576698